[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#825862: marked as done (qrq: segfault using pulseaudio at qrs)

Your message dated Sun, 02 Jul 2017 12:49:09 +0000
with message-id <E1dReJJ-000Bot-0t@fasolo.debian.org>
and subject line Bug#825862: fixed in qrq 0.3.1-3
has caused the Debian Bug report #825862,
regarding qrq: segfault using pulseaudio at qrs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
825862: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=825862
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qrq
Version: 0.3.1-1
Severity: normal
Tags: patch

Dear Maintainer,

I'm running qrq using pulseaudio (as is the default on my system).
I've configured the speed to slower than normal, and then goofed quite a bit.
This led to slower and slower speeds and finally to quite reproducible
segfaults.

Investigating, I found that pulseaudio.c reserves a fixed buffer
which is good for 10 seconds.  If a long callsign at slow speed exceeds that
limit, a segfault results.

Fortunately, it is easy to replace the fixed buffer with a dynamically
allocated one that is enlarged dynamically as needed.

Find a patch to this respect included.

Regards, and thank you for providing fine software,

Andreas, DJ3EI.



-- System Information:
Debian Release: 8.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages qrq depends on:
ii  libc6        2.19-18+deb8u4
ii  libncurses5  5.9+20140913-1+b1
ii  libpulse0    5.0-13
ii  libtinfo5    5.9+20140913-1+b1

qrq recommends no packages.

Versions of packages qrq suggests:
pn  gnuplot  <none>

-- no debconf information


Common subdirectories: qrq-0.3.1/.pc and qrq-mine/.pc
Common subdirectories: qrq-0.3.1/OSXExtras and qrq-mine/OSXExtras
Common subdirectories: qrq-0.3.1/debian and qrq-mine/debian
diff -u qrq-0.3.1/pulseaudio.c qrq-mine/pulseaudio.c
--- qrq-0.3.1/pulseaudio.c	2013-01-06 15:14:09.000000000 +0100
+++ qrq-mine/pulseaudio.c	2016-05-30 22:19:03.214507268 +0200
@@ -29,7 +29,8 @@
 extern long samplerate;
 extern void  *dsp_fd;
 
-short int buf[441000];		/* 10 secs buffer */
+short int *buf = 0;
+int bufsize = 0;
 int bufpos = 0;
 
 void *open_dsp () {
@@ -64,8 +65,13 @@
 /* actually just puts samples into the buffer that is played at the end 
 (close_audio) */
 void write_audio (void *bla, int *in, int size) {
+	int sample_count = size/sizeof(int);
 	int i = 0;
-	for (i=0; i < size/sizeof(int); i++) {
+	if(bufsize <= bufpos + sample_count) {
+		buf = realloc(buf, (bufpos + sample_count) * sizeof(short int));
+		bufsize = bufpos + sample_count;
+	}
+	for (i=0; i < sample_count; i++) {
 		buf[bufpos] = (short int) in[i];
 		bufpos++;
 	}

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: qrq
Source-Version: 0.3.1-3

We believe that the bug you reported is fixed in the latest version of
qrq, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 825862@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Tuckley <colint@debian.org> (supplier of updated qrq package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 02 Jul 2017 13:15:00 +0100
Source: qrq
Binary: qrq
Architecture: source amd64
Version: 0.3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Colin Tuckley <colint@debian.org>
Description:
 qrq        - high speed morse trainer, similar to DL4MM's Rufz
Closes: 825862 834932
Changes:
 qrq (0.3.1-3) unstable; urgency=medium
 .
   * Fix segfault using pulseaudio at qrs bug (Closes: #825862)
     patch from Andreas, DJ3EI
   * Bump Standards-Version to 3.9.8
   * Make stastics plot persistent (Closes: #834932)
     patch from Bernhard Kneip
Checksums-Sha1:
 8431a86d7eef64b4ea0b28e619a4f3b4fa0e23e9 1870 qrq_0.3.1-3.dsc
 881f265ca8842fd59baf6ba219126587a9fb410e 4524 qrq_0.3.1-3.debian.tar.xz
 9d35ece6b22c79fe80733d5b2db5bfd0c909c447 7244 qrq_0.3.1-3_amd64.buildinfo
 74a967d6da224903fe420a039bdc55e0ad74e889 89098 qrq_0.3.1-3_amd64.deb
Checksums-Sha256:
 c66aedce3204328b351a78a4ae6fb6e047bfaa0e5ab5f2c546674d9bd7bd4b79 1870 qrq_0.3.1-3.dsc
 0fd256e8f34bcd67e0c7973101aaa9d7d30b1c466f77fc8161f6c1cffb98ff44 4524 qrq_0.3.1-3.debian.tar.xz
 11f71d243a82de296b36beb3659e646f9d572009ba31be3c13093f3ae375145f 7244 qrq_0.3.1-3_amd64.buildinfo
 9c374829c0a5b1318e10b582d51d3786aa47522abc48c04a77fdef7ea8598209 89098 qrq_0.3.1-3_amd64.deb
Files:
 f51819cbfcd169cc0c3509c09a322381 1870 hamradio extra qrq_0.3.1-3.dsc
 4b2b21cc93f4bf26d4b2e16fe91841ab 4524 hamradio extra qrq_0.3.1-3.debian.tar.xz
 4b6eb85934ecd6f63d04d11ea15f25c6 7244 hamradio extra qrq_0.3.1-3_amd64.buildinfo
 7ad9f00ce1a1b947131d328b4dd5c04a 89098 hamradio extra qrq_0.3.1-3_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEq4t0jL2QJYBE2VXS+gxBBzjJ2QMFAllY5T4ACgkQ+gxBBzjJ
2QMIwQ/+N+cifUX9inDkcILXH1NHDKkkxGGrtJHpsUfayEgPK21m24FA0PTDYIJc
JPDEb7KkuvsUtcRYrzYM/46BXjtom0xfs3XbbGN8/vmCWISsTyJlF/Eija/3Amif
LWXlEyKPQe/DBuiEQoapPOhsZh7RIgEqAvRTWsiUX16aGs7gVMDJLk1PS6mYMy8N
YV62eY7SVILZyYQXB3mYjm4vpmiuEVEUuiRZGXASkK0Cy8ga+v3f/u/NQekooD86
B4qz1a75qdelYTXF86YiCcHSSnRpyr5XLrwM6Pb0F02Xk9mAq/621zQYXh2nrr3G
1Tsb0Vxv/T4z9CvVRfGyl760pcIaMjzNmAujaUbsF8lmMH6HKQAJxVHoSzbwhF99
gWLE9N61azP2H3koVXkKsyg5PUf7IfU20leA6pcTtUv/kjoj1bLq5k4jaNtg82ze
5n0OH48lIpJDUprVrTy3fPvdhqyzx5YDpi1I0ZTRxjd8fyvIwgJgOg1xcoc9pm8C
VOwHvqbS4R2wNSlh5yiyDoRFxKcRieGwyTUEcKv5ts0EiGk9h4HSxjfDLEfFgmk0
X3xCBeiXkd4KDnG3oCgI0iLevBdDntMBvA47DbaK7WWM2AhX6Irlbn26BDKsOjz5
KFaK+lxDht89WSoISk2Ax9xMrDadgZ2BVKpMTUtyxA7H1dJh1eE=
=v5QO
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: