Bug#849249: fldigi: Icon improvements

Hi Jeremy-

Thanks for these fldigi patches -- I'm applying 0001 to fix the icons, but not applying 0002 (the debian/rules cleanups), because this packaging is still debian/compat==7 so it really does need the special dpkg-buildflags handling to get build hardening. Moving up to debhelper 9 is surely a good idea, but lets handle that under separate cover -- I'll look at applying your 0002 patch again whenever I or you or someone else gets to that work.

Thanks again for the icon fix!

-Kamal

On Fri, Dec 23, 2016 at 10:15 PM, Jeremy Bicha <jbicha@ubuntu.com> wrote:

Package: fldigi
Version: 3.23.14-1
Tags: patch

.xpm app icons are not necessary any more. If a package contains .xpm
icons, it triggers an error in appstream. This means that fldigi does
not show up in the GNOME Software app which is installed by default in
the GNOME desktop in Debian stretch.

https://appstream.debian.org/sid/main/issues/fldigi.html
https://wiki.debian.org/AppStream/Guidelines#Icon_best_practices

The .png app icons are installed in the wrong directory. They should
be installed in a two-number directory like 64x64/ instead of a
one-number directory like 64/

There's some extra line in debian/rules. The dh_installdocs override
isn't needed since there's only one binary package.
--disable-silent-rules is the default as of debhelper 9.20150501. And
dpkg-buildflags should be passed automatically without you having to
do anything.

I'm attaching patches for these.

Thanks,
Jeremy