[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#782233: marked as done (cwirc: please make the build reproducible)

Your message dated Tue, 05 May 2015 15:50:06 +0000
with message-id <E1Ypf6k-0002Jg-R9@franck.debian.org>
and subject line Bug#782233: fixed in cwirc 2.0.0-8
has caused the Debian Bug report #782233,
regarding cwirc: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
782233: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782233
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cwirc
Version: 2.0.0-7
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-CC: reproducible-builds@lists.alioth.debian.org

Hi!

While working on Debian's “reproducible builds” effort [1], we have
noticed that cwirc doesn't build reproducibly.
It embeds the current date into the manpage.

The attached patch fixes this by using the last changelog date
as a timestamp that will be embedded.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds




















diff --git a/debian/patches/reproducible_build.patch b/debian/patches/reproducible_build.patch
new file mode 100644
index 0000000..8f7713f
--- /dev/null
+++ b/debian/patches/reproducible_build.patch
@@ -0,0 +1,16 @@
+Author: Reiner Herrmann <reiner@reiner-h.de>
+Description: Remove timestamp from binary to enable reproducible builds.
+
+Index: cwirc-2.0.0/gui.c
+===================================================================
+--- cwirc-2.0.0.orig/gui.c
++++ cwirc-2.0.0/gui.c
+@@ -1175,7 +1175,7 @@ int cwirc_ui(int ext_shmid)
+ 
+   /* Create the general information label inside the table */
+   label=gtk_label_new("CWirc - IRC Morse code chat application\n"
+-		"Version: " VERSION ", build date: " __DATE__ "\n"
++		"Version: " VERSION "\n"
+ 		"(c) Pierre-Philippe Coupard <pcoupard@skynet.be>\n\n"
+ 		"This program is distributed under the terms of the GNU "
+ 				"General Public License");
diff --git a/debian/patches/series b/debian/patches/series
index 71dc940..d731607 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 0000-fix-ftbfs-with-ld-as-needed.patch
 makefile-adoptions-for-hardening.patch
+reproducible_build.patch
diff --git a/debian/pod2man.mk b/debian/pod2man.mk
index 64bc797..f878a28 100644
--- a/debian/pod2man.mk
+++ b/debian/pod2man.mk
@@ -34,9 +34,10 @@ endif
 PACKAGE		?= package
 
 # Optional variables to set
+BUILD_DATE	?= $$(dpkg-parsechangelog -S Date -lchangelog)
 MANSECT		?= 1
 PODCENTER 	?= User Commands
-PODDATE		= $$(date "+%Y-%m-%d")
+PODDATE		= $$(date -u "+%Y-%m-%d" -d "$(BUILD_DATE)")
 
 # Directories
 MANSRC		=

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: cwirc
Source-Version: 2.0.0-8

We believe that the bug you reported is fixed in the latest version of
cwirc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 782233@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Tuckley <colint@debian.org> (supplier of updated cwirc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 05 May 2015 16:04:10 +0100
Source: cwirc
Binary: cwirc
Architecture: source amd64
Version: 2.0.0-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Colin Tuckley <colint@debian.org>
Description:
 cwirc      - X-Chat morse plugin
Closes: 782233
Changes:
 cwirc (2.0.0-8) unstable; urgency=medium
 .
   * Make build reproducible - patch from Reiner Herrmann <reiner@reiner-h.de>
     (Closes: #782233)
   * Bump Standard-Version to 3.9.6
Checksums-Sha1:
 df81f9be11fb83b42453872ec4ba9e78d7141628 1894 cwirc_2.0.0-8.dsc
 da16f9ba287e63a03554d2077e6e931bbb19d34c 10204 cwirc_2.0.0-8.debian.tar.xz
 37b2cbc6281c8b451eb64e787efba916b76370e4 153058 cwirc_2.0.0-8_amd64.deb
Checksums-Sha256:
 b88571a9d1e063d3043ee19e8bb6a940122c9f0ed07490a8df2b61a66dc2a1e7 1894 cwirc_2.0.0-8.dsc
 ab025323d418f3be6551fc4acd6ad2b0b3bd016491291a5d498fb3a0d85002a1 10204 cwirc_2.0.0-8.debian.tar.xz
 e8cd80a38f516153b19b5bbb061d14571bfe0c60982a1565caee45d598137b52 153058 cwirc_2.0.0-8_amd64.deb
Files:
 c2729aa1e268461e46e49d20aaad27d1 1894 hamradio optional cwirc_2.0.0-8.dsc
 44fcf07e09e0af5873c861cfc090371f 10204 hamradio optional cwirc_2.0.0-8.debian.tar.xz
 a1aea6b4ac33feba82dc71da506a3366 153058 hamradio optional cwirc_2.0.0-8_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJVSN5eAAoJEPoMQQc4ydkDdWIP/0DrP/ozgHf/DEmpLfdBOYhP
ksHxAtK/exMP0HblhIwlrgk3HoKtFmNRLuPxTr2dUKesGna3QG88h96CTtkfK3cF
u+ARIzR0UqwZ3hZFl3hVci1rwINpk8PcJkU/aePjtWkpokjVRwLdebhXmuaJcu3+
bnAY+aTm1KYft5ZN6H67seCLEYKRndYYNmuGBVJZPjXql/11WoBw2cfR/AgCGEUB
Py751Ucf2v6cEc56vE3dXQ1AGZXxYlrUM33fWI4S8u7PGCmjkoiasC5xA7Mu5atd
CX7xH+Nwv3fuo/VAc4YZxWy+Uxk3N2hWUODbqjkofDbeh9iVmylv0eFTxcJxWEzM
xBsbvk3+oMXtilW1eMqPbTUWIg865SOMSRxtqUtxl8kCBnoEYYpcTg6PXvkTBM3b
xOhoqlDUXSklFJzDjzSAmcqoA/vWsgUTdb2AX4MZT3iaUJ/tmkcFCGPmIofij52t
zJ7fJxcOTQn3mTuZsPg03avBx7oaWwC5toOfv5GEvhGg69r+Kmdljq/rOykHnHs8
yxiB+39TF1KZa7QqCPuBKlCW5SI1oyN+iB7E029oSD9h9afg4pZ2IzMotdVCL1bq
vd4k50J2hhT9lg1GTQAnXPSucRDJxgylJ2Qaifo/0s7VT496SmKKor2W3D8ecs3e
8PPr9GiHFPRqZSlUIyEW
=RcpL
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: