[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692820: cqrlog ftbfs on armel and armhf, outdated embedded copy of freepascal ipc code.



package: cqrlog
severity: important

cqrlog fails to build on armel and armhf with the following error

400 93.865/102.848 Kb Used
ipccall.inc(52,36) Error: Identifier not found "syscall_nr_ipc"
ipccall.inc(59,37) Error: Identifier not found "syscall_nr_ipc"
100 93.923/102.848 Kb Used

I traced this to an old embedded copy of the ipc code from the
freepascal rtl in src/ipc which does not support those architectures.
The readme in that directory has the following to say.

 >Files with fixed bug in ipc_sys:
http://bugs.freepascal.org/view.php?id=14075
 >
 >This units will be removed after relase fpc 2.4.4.

I attach a debdiff which disables use of the embedded copy of the
freepascal ipc code and bumps the freepascal related build-dependencies
to >= 2.4.4 . I have tested that with this patch the package builds on
armhf. I have not done any further tests and would suggest anyone
planning to upload (as either mu or nmu) does so. I do not intend to nmu
this myself.


diff -Nru cqrlog-1.4.1/debian/changelog cqrlog-1.4.1/debian/changelog
--- cqrlog-1.4.1/debian/changelog	2012-05-04 18:09:18.000000000 +0000
+++ cqrlog-1.4.1/debian/changelog	2012-11-08 20:26:41.000000000 +0000
@@ -1,3 +1,12 @@
+cqrlog (1.4.1-1.1) UNRELEASED; urgency=low
+
+  * disable local copy of freepascal ipc code which is broken on armel/armhf
+    and was supposed to be removed after the release of fpc 2.4.4 (according to
+    the readme)
+  * version fpc related build-depends as >= 2.4.4
+
+ -- Peter Michael Green <plugwash@debian.org>  Thu, 08 Nov 2012 20:20:49 +0000
+
 cqrlog (1.4.1-1) unstable; urgency=low
 
   * keys in CW Fx window also send CW messages
diff -Nru cqrlog-1.4.1/debian/control cqrlog-1.4.1/debian/control
--- cqrlog-1.4.1/debian/control	2012-05-04 18:09:18.000000000 +0000
+++ cqrlog-1.4.1/debian/control	2012-11-08 20:26:20.000000000 +0000
@@ -3,7 +3,7 @@
 Priority: extra
 Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
 Uploaders: Petr Hlozek <petr@ok2cqr.com>, Kamal Mostafa <kamal@whence.com>
-Build-Depends: debhelper (>= 7), lazarus (>= 0.9.29) | lazarus-0.9.30, lcl (>= 0.9.30) | lcl-0.9.30, fp-utils, fp-units-misc, fp-units-gfx, fp-units-gtk, fp-units-db, libhamlib-dev (>= 1.2.10)
+Build-Depends: debhelper (>= 7), lazarus (>= 0.9.29) | lazarus-0.9.30, lcl (>= 0.9.30) | lcl-0.9.30, fp-utils (>= 2.4.4), fp-units-misc (>= 2.4.4), fp-units-gfx (>= 2.4.4), fp-units-gtk (>= 2.4.4), fp-units-db (>= 2.4.4), libhamlib-dev (>= 1.2.10)
 Standards-Version: 3.9.2
 Homepage: http://www.cqrlog.com
 
diff -Nru cqrlog-1.4.1/debian/patches/no-local-ipc-code cqrlog-1.4.1/debian/patches/no-local-ipc-code
--- cqrlog-1.4.1/debian/patches/no-local-ipc-code	1970-01-01 00:00:00.000000000 +0000
+++ cqrlog-1.4.1/debian/patches/no-local-ipc-code	2012-11-08 20:19:21.000000000 +0000
@@ -0,0 +1,31 @@
+Description: don't use local ipc code
+ The package contains a local copy of the ipc code from the fpc rtl, supposedly
+ this code was to work arround a bug and was to be removed after the release
+ of fpc 2.4.4 but it is still present. Furthermore the local copy of the code
+ does not seem to work on armel/armhf.
+
+ This patch disables use of the local copy of the ipc code making the project
+ use the version from the fpc rtl.
+Author: Peter Michael Green <plugwash@debian.org>
+
+--
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: http://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: <YYYY-MM-DD>
+
+--- cqrlog-1.4.1.orig/src/cqrlog.lpi
++++ cqrlog-1.4.1/src/cqrlog.lpi
+@@ -628,7 +628,7 @@
+     <Version Value="9"/>
+     <SearchPaths>
+       <Libraries Value="$(LazarusDir)/lcl"/>
+-      <OtherUnitFiles Value="lnet/lib;ipc;mysql"/>
++      <OtherUnitFiles Value="lnet/lib;mysql"/>
+       <SrcPath Value="$(LazarusDir)/lcl;$(LazarusDir)/lcl/interfaces/$(LCLWidgetType)"/>
+       <LCLWidgetType Value="gtk2"/>
+     </SearchPaths>
diff -Nru cqrlog-1.4.1/debian/patches/series cqrlog-1.4.1/debian/patches/series
--- cqrlog-1.4.1/debian/patches/series	1970-01-01 00:00:00.000000000 +0000
+++ cqrlog-1.4.1/debian/patches/series	2012-11-08 20:16:31.000000000 +0000
@@ -0,0 +1 @@
+no-local-ipc-code


Reply to: