Bug#690626: ax25-tools: bashism in /bin/sh script
done
On 2012-10-16 22:19:51 +0200, Thomas Osterried <thomas@x-berg.in-berlin.de>
wrote in <[🔎] 20121016201951.GI32411@x-berg.in-berlin.de>:
> On 2012-10-15 21:51:15 -0500, Raphael Geissert <atomo64@gmail.com>
> wrote in <[🔎] 201210152151.16178.atomo64@gmail.com>:
> > Package: ax25-tools
> > Version: 0.0.10-rc2+cvs20120204-3
> > Severity: important
> > User: debian-release@lists.debian.org
> > Usertags: goal-dash
> >
> > Hello maintainer,
> >
> > While performing an archive wide checkbashisms (from the 'devscripts'
> > package) check I've found your package containing a /bin/sh script making
> > use of a bashism.
> >
> > checkbashisms' output:
> > >possible bashism in ./usr/sbin/rsusers line 9 (echo -e):
> > >echo -en "Linux/ROSE 001. AX.25, NET/ROM and ROSE Users.\r"
> > >possible bashism in ./usr/sbin/rsusers line 46 (echo -e):
> > > echo -en "\r"
> > >possible bashism in ./usr/sbin/rsusers line 84 (echo -e):
> > > echo -en "\r"
> > >possible bashism in ./usr/sbin/rsusers line 122 (echo -e):
> > > echo -en "\r"
>
> I'll change this to
> printf "Linux/ROSE 001. AX.25, NET/ROM and ROSE Users.\r"
>
> > >possible bashism in ./usr/sbin/rsusers line 125 (read without variable):
> > >read
>
> Can't say why the original auther liked to read a line for discarding
> after the program has run.
>
> vy 73,
> - Thomas dl9sau
>
> > Not using bash (or a Debian Policy conformant shell interpreter which
> > doesn't provide such an extra feature) as /bin/sh is likely to lead to
> > errors or unexpected behaviours.
> >
> > You can find hints about how to fix bashisms at:
> > https://wiki.ubuntu.com/DashAsBinSh
> >
> > Thank you,
> > Raphael Geissert
> >
> >
> > --
> > To UNSUBSCRIBE, email to debian-hams-REQUEST@lists.debian.org
> > with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> > Archive: [🔎] 201210152151.16178.atomo64@gmail.com">http://lists.debian.org/[🔎] 201210152151.16178.atomo64@gmail.com
> >
>
>
> --
> To UNSUBSCRIBE, email to debian-hams-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: [🔎] 20121016201951.GI32411@x-berg.in-berlin.de">http://lists.debian.org/[🔎] 20121016201951.GI32411@x-berg.in-berlin.de
>
Reply to: