Bug#628864: Seg fault on get_menu_item / Debian Bug#628864: Fldigi fails to start, gives getMenuItem error

[Nate Bargmann <n0nb@n0nb.us>]

* On 2011 11 Jun 19:20 -0500, Kamal Mostafa wrote:
> Small patch (attached) fixes the problem.
> 
> In a nutshell, the 'menu_' array in dialogs/fl_digi.cxx gets prematurely
> terminated, because 'mode_info[MODE_ANALYSIS].name' ends up as an empty
> string in the menu_ table.  That happens because the 'mode_info' array
> in globals/globals.cxx uses an internationalized string to fill that
> value _("Freq Analysis").  Something about the internationalization
> runtime string juggling breaks down, leaving menu_ broken.
> 
> Simply using a regular string for "Freq Analysis" fixes all the damage.
> For the record, I do not understand why this problem is only manifesting
> now, however that fix seems easy and appropriate.
> 
> I'll apply this to fldigi 3.21.10 in Debian unstable.  Dave, if you
> would be so kind, please apply it to your main tree as well.

Confirmed working for me.  Sorry I'm late to the party again.

73, de Nate >>

-- 

"The optimist proclaims that we live in the best of all
possible worlds.  The pessimist fears this is true."

Ham radio, Linux, bikes, and more: http://www.n0nb.us