[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#548960: marked as done (fails to build with newer eglibc (local definition of round))

Your message dated Sat, 23 Jan 2010 15:21:50 +0100
with message-id <20100123142150.GA29584@feivel.credativ.lan>
and subject line Closing
has caused the Debian Bug report #548960,
regarding fails to build with newer eglibc (local definition of round)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
548960: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548960
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fbb
Version: 7.04j-8
Severity: normal
Tags: patch

Hi,

thanks for maintaining fbb.

During Ubuntu's rebuild test, fbb failed to build with gcc-4.4 in conjunction
with a newer eglibc [1].

The reason is that eglibc nowadays defines round (as per C99).

A simple fix is to simply use round from <math.h>, eradicating the local
definition. Probably better is to check for round with feature_test_macros.

The attached patch simply removes the local definition. Admitted, I haven't 
checked if this does build on unstable yet :(.

Cheers,
    Stefan.

[1]:
<http://launchpadlibrarian.net/31645656/buildlog_ubuntu-karmic-amd64.fbb_7.04j-8_FAILEDTOBUILD.txt.gz>

-- System Information:
Debian Release: squeeze/sid
  APT prefers karmic-updates
  APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.31-10-generic (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- fbb-7.04j.orig/src/trajec.c
+++ fbb-7.04j/src/trajec.c
@@ -110,8 +110,6 @@
 
 static double julien (double, int, int, int, int, int);
 
-static int round (double);
-
 static long julien_to_pc (double);
 
 static void calc1_trajec (void);
@@ -127,15 +125,6 @@
 static void satpos (void);
 static void satsta (void);
 
-
-static int round (double val)
-{
-	if (val > 0.0)
-		return ((int) (val + 0.5));
-	else
-		return ((int) (val - 0.5));
-}
-
 static double julien (double d3, int n3, int y3, int h3, int m3, int s3)
 {
 	double j8;

--- End Message ---
--- Begin Message --- 
As the patch was already applied in 7.04j-8.1 I think we can safely close this report.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes@jabber.org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

--- End Message ---
Reply to: