Dmitry <debian@dmitry.ms> writes: >> Could you compare your work with this: >> >> https://salsa.debian.org/go-team/packages/ssh-tpm-agent >> https://salsa.debian.org/jas/ssh-tpm-agent/-/pipelines/979686 >> >> ? > > My packages also building > > The main difference is in that you now avoiding dependency on the > go-tpm-tools (and updating go-tpm accordingly), and as a result, skip > tests that require use of simulator. I built these two packages also > and managed all tests to pass > > go-tpm-tools was entirely based on your repository > https://salsa.debian.org/jas/golang-github-google-go-tpm-tools, but I > used a newer upstream version > > go-tpm has been slightly updated to use the new go-tpm-tools > > However, my ssh-tpm-agent package drops support for > ssh-tpm-ca-authority meanwhile, while yours does not. I don't know > which approach is better > > There are also several minor differences, like in the watch file; your > salsa-ci.yml includes an additional pipeline I haven't heard of > before, etc > > Among the significant differences, I also added a patch that removes > the manual installation of systemd files, leaving it for dpkg, thus > making it more Debian-way Thank you! Once 'ssh-tpm-agent' leaves NEW, let's make some of those changes -- the systemd stuff seems great. Updating go-tpm packages stalled on some dependency, I think, but resuming that would be nice too. I think vendoring ssh-tpm-ca-authority is okay here, this is an opt-in feature so it doesn't come as a surprise to the user, and having it available seems it may help get confidence in stability of that dependency. /Simon
Attachment:
signature.asc
Description: PGP signature