[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Getting golang-google-grpc version 1.66.3-1 from experimental to sud



Dear Dmitry and Shengjing,

I have just uploaded `golang-google-grpc` version 1.66.3-1 to experimental, it is currently building. I need it for updating docker.io to version 27.

While updating the package, I noticed that the `debian/README.source` file at https://sources.debian.org/src/golang-google-grpc/1.64.0-7/debian/README.source contains the following warnings:

From Dmitry Smirnov:
"This package is very sensitive. It must be in sync with "golang-goprotobuf-dev". Failure to re-build generated files in this package lead to FTBFS in dozens of packages."

From Shengjing Zhu:
"There's a circular dependency in this package, it has `golang-google-genproto-dev` in Build-Depends, which depends this package as well. To break this, we vendor the original protobuf definitions for rpc functionality, from the following repos and commits: [https://github.com/grpc/grpc-proto/tree/master/grpc](https://github.com/grpc/grpc-proto/tree/master/grpc) at commit da219ab. [https://github.com/googleapis/googleapis/tree/master/google/rpc](https://github.com/googleapis/googleapis/tree/master/google/rpc) at commit ae909b8."

Given that these statements are quite old and the package (as well as its reverse dependencies) builds fine, I'm unclear on the current state of affairs and would appreciate your guidance.

Specifically, could you please clarify:
* Does the information quoted from `debian/README.source` still apply to the current version of the package?
* Since the reverse builds have succeeded (as seen at [https://salsa.debian.org/go-team/packages/golang-google-grpc/-/pipelines/954678](https://salsa.debian.org/go-team/packages/golang-google-grpc/-/pipelines/954678)), is it safe to upload `golang-google-grpc` to unstable?
* Do we need to update the original protobuf definition for rpc functionality to newer commits? If so, which ones?
* What other considerations might I have missed regarding this package's dependencies and build process?
* How can we clarify or correct the `README.source` to ensure future packagers have clear, up-to-date instructions?

Thank you for your insights.

Best regards,
Reinhard


--
regards,
    Reinhard

Reply to: