[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updating golang-golang-x-tools?



On 02/03/2025 11:29, Nicolas Peugnet wrote:
On 02/03/2025 10:02, Nicolas Peugnet wrote:
I will also try to see if it can be solved by backporting a patch as easily as for the x-exp package, but I can not promise anything.

I bisected it and the first working commit is [2db563b], but it is too difficult to backport on its own because it depends on other changes elsewhere in the code.

Instead, I tried to import v0.25.0 which is the first release that contains this commit, but there are a few failing tests. I will try to fix these and propose an upload of this version.

[2db563b] https://github.com/golang/tools/ commit/2db563b1a3a2d4a703682ea03482335f63323a26

So, I have a working package for v0.25.0 here if one of you want to take a look and make an upload based on it:
https://salsa.debian.org/n-peugnet/golang-golang-x-tools

I can push it directly to the team's repo if you want me to.

I chose v0.25.0 as this is the first version that fixes our problem with stringer. It had less failing tests than v0.30.0 and less changes overall (same binaries produced, etc.), so I hope that it will cause less breaking for other packages.

I had to backport two patches from upstream to fix two test failures with go 1.24, and I had to add a new patch to fix one last test failure specific to Debian.

I can confirm that it fixes the current failure for etcd, but as I said in another thread, etcd has one last test failure to fix to make it compatible with go 1.24, but it should be trivial. I will propose a merge request once stringer is fixed.
--
Nicolas Peugnet


Reply to: