[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: update protobuf



I currently do not have the time to build everything but maybe this helps:

On 13/02/25 4:51 pm, Félix Sipma wrote:
> ratt returns only 3 failures:
> - zabbix: seems related
>      # google.golang.org/protobuf/internal/errors
>      vendor/google.golang.org/protobuf/internal/errors/errors.go:20:25: predeclared any requires go1.18 or later (-lang was set to go1.17; check go.mod)
>      vendor/google.golang.org/protobuf/internal/errors/errors.go:46:37: predeclared any requires go1.18 or later (-lang was set to go1.17; check go.mod)
>      vendor/google.golang.org/protobuf/internal/errors/errors.go:70:28: predeclared any requires go1.18 or later (-lang was set to go1.17; check go.mod)

protobuf that is vendored with zabbix is removed here:
https://sources.debian.org/src/zabbix/1%3A7.0.9%2Bdfsg-1/debian/copyright/#L50

But since modules.txt contains explicit declaration of go 1.17 here:
https://sources.debian.org/src/zabbix/1%3A7.0.9%2Bdfsg-1/vendor/modules.txt/#L258

Maybe dropping it will help.

> - gitaly: seems unrelated
>      ...
>      cannot find package "github.com/gogo/protobuf/proto"
>      ...
>      cannot find package "github.com/gogo/protobuf/types"

IIRC these 2-3 protobuf packages are tightly coupled. Is the update
breaking other (proto) packages by any chance?

I do see /proto and /types at
https://packages.debian.org/sid/all/golang-github-gogo-protobuf-dev/filelist

> - gitlab-ci-multi-runner: not sure
>      # gitlab.com/gitlab-org/gitlab-runner/helpers/docker
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:27:51: undefined: types.ContainerListOptions
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:33:36: undefined: container.ContainerCreateCreatedBody
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:34:72: undefined: types.ContainerStartOptions
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:41:17: undefined: types.ContainerAttachOptions
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:43:73: undefined: types.ContainerRemoveOptions
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:48:22: undefined: container.ContainerWaitOKBody
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:49:69: undefined: types.ContainerLogsOptions
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:63:51: undefined: volume.VolumeCreateBody
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:63:76: undefined: types.Volume
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:65:61: undefined: types.Volume
>      src/gitlab.com/gitlab-org/gitlab-runner/helpers/docker/client.go:65:61: too many errors

This looks unrelated and this package has been out of testing since 4
years. The failure looks related to docker library version mismatch.

-n


Reply to: