Re: ITP: golang-github-go-task-slim-sprig -- Useful template functions for Go templates.
Hi,
I have done the packaging (from Mark's existing packaging, thank you!) for the
new version 3.0.0. I hope to upload to the NEW queue tomorrow; but first I
need to get the Git repo in good shape.
@Mark, I made slight changes to the packaging but you are still marked as an
Uploader alongside me, I have left your copyright in d/copyright, and your
packaging commit authorship is in d/changelog. I hope that is acceptable by
you :-)?
@Go Team, Can I have maintainer access to
https://salsa.debian.org/go-team/packages/golang-github-go-task-slim-sprig ?
Currently I am just developer on that repo, it'd be great to get full access
so I can modify CI setting etc.
Thanks!
Chris
On Wed, 2024-01-10 at 17:24 +0000, Christopher Obbard wrote:
> Hi Mark,
>
> Did you think about my comments below? I would like to upload this package
> into the NEW queue over the next couple of weeks (so to not block a new
> imminent version of debos from being included in the archive).
>
> Please do let me know if you have time to make the changes, or alternatively
> if you do not have the time. I can make the changes to the packaging, but I
> do
> not want to duplicate effort.
>
> Thanks!
> Chris
>
> On Thu, 2023-12-07 at 18:57 +0000, Christopher Obbard wrote:
> > Hi Mark,
> >
> > I will be willing to sponsor this package (mainly as I am looking to using
> > it
> > in Debos). Your packaging looks generally good, but I have noticed a few
> > minor
> > issues with the Git repo / packaging, let me know if you can fix these or
> > if
> > you'd like me to do so.
> >
> > - d/copyright: "Copyright: 2019 Task" seems.. wrong? Also, for the record
> > there is no explicit licence file in the upstream repository, but the
> > GitHub
> > page says MIT.
> >
> > - The package's commit history seems to modify the original source, e.g.
> > 908e6bca ("Ignore _build and quilt .pc dirs via .gitignore") which is then
> > reverted by af533953 ("Import Debian changes 2.20.0-1"). It would be far
> > cleaner to drop these commits.
> >
> > - 6ef11ba6 ("fixup: unstable build submission") seems to be wrong. As
> > you're
> > not uploading into unstable, you should leave it as UNRELEASED.
> >
> > - v3.0.0 has been released upstream. What would the plan be for importing
> > that?
> >
> > - The TestShuffle function seems to fail (heh, is this test even
> > deterministic
> > ?):
> >
> > > $ gbp buildpackage --git-pbuilder
> > > === RUN TestShuffle
> > > functions_test.go:82:
> > > Error Trace: /build/golang-github-go-task-slim-
> > > sprig-
> > > 2.20.0/_build/src/github.com/go-task/slim-sprig/functions_test.go:82
> > > Error: Received unexpected error:
> > > Expected 'rldo HWlloe', got 'olldolr
> > > WeH'
> > > Test: TestShuffle
> > > --- FAIL: TestShuffle (0.00s)
> > >
> > > dh_auto_test: error: cd _build && go test -vet=off -v -p 16
> > > github.com/go-
> > > task/slim-sprig returned exit code 1
> >
> >
> >
> > Thanks!
> >
> > Chris
Reply to: