Otto Kekäläinen <otto@debian.org> writes: > Hi, > > If anyone has spare time to review, I'd like to get feedback about > https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-cobra/-/commits/debian/latest Looks good to me! To be able to identify any nit-pick at all, I have to go the Go team workflow documentation -- https://go-team.pages.debian.net/workflow-changes.html -- which says, for example, to use wrap-and-sort -at. Looks like you used -satbk instead. I happen to do the same for all my Go packages, so it is hard to blame you, but for consistency this may be bad. > Note that in this Go team repository I enabled the shared runner, so > it is running both the gi-ci and Salsa CI (and all of it is passing): > https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-cobra/-/pipelines/770352 > > I have proposed this same CI extension Go team-wide in > https://salsa.debian.org/go-team/infra/pkg-go-tools/-/merge_requests/2 > as well. This is great -- but do we need to use upstream/downstream for this? Can't just all the Salsa CI jobs be added to the regular gitlab pipeline? I find upstream/downstream clicking ugly. I didn't look too closely at the code to understand if there is any fundamental reason for this, is there? /Simon
Attachment:
signature.asc
Description: PGP signature