Re: Review of prometheus-phpfpm-exporter and golang-github-tomasen-fcgi-client and

[Otto Kekäläinen <otto@debian.org>]

Hi!

On Thu, 10 Oct 2024 at 04:40, Otto Kekäläinen <otto@debian.org> wrote:
>
> Hi!
>
> There are two new Go packages pending review at
>
> https://mentors.debian.net/package/prometheus-phpfpm-exporter/
> (https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter/)
>
> https://mentors.debian.net/package/golang-github-tomasen-fcgi-client/
> (https://salsa.debian.org/go-team/packages/golang-github-tomasen-fcgi-client/)
>
> I am happy to mentor Nicolas and upload the packages, and they seem
> good to me, but to be diligent I would like to request a Go expert in
> the Go team to do at least one review of these before I upload.

I posted my review at
https://mentors.debian.net/package/golang-github-tomasen-fcgi-client/#upload-3
and will most likely upload after Nicola's next update.

> Also, after browsing https://go-team.pages.debian.net/ and
> https://go-team.pages.debian.net/ci.html I am a bit confused why isn't
> the CI running any of the regular build/re-build/Lintian/reproducible
> builds etc jobs?
>
> I imagine they would be good to run at least once before a upload to
> validate that all basic requirements for a high quality package are
> met. Additionally, the pipeline at
> https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter/-/pipelines/740718
> only runs tests on the package and dependencies. In that job some
> tests fail to download the package to be tested and fail, but the job
> still passes. Can somebody share a bit context here to make me
> understand what is the rationale of this?

I figured out how to do this in
https://salsa.debian.org/otto/golang-github-tomasen-fcgi-client/-/commit/2d637d70cd437de0b55a4bb1f22ea2660218389f
and ran Salsa CI pipeline at
https://salsa.debian.org/otto/golang-github-tomasen-fcgi-client/-/pipelines