On 25/8/24 12:13 PM, Nilesh Patra wrote:
Praveen is the best person to take care of this but is a new package for this really necessary?
gitlab is already very complicated, so it'd be better to have this as a separate package.
Can't it be downloaded/installed in gitlab's pre-inst scripts?
I do it in postinst usually, but I'm not sure about pre-inst. Also we need to handle gitaly as systemd service and gitaly can be installed stand alone on a separate machine than gitlab as well.
In totality this is a grand total of just 50 line code (45 line code and 6 line conf file) and it should not be difficult to have it as part of gitlab? You also seem to have a new binary package https://salsa.debian.org/vivekkj/gitaly-installer/-/blob/master/debian/gitlab-common.install?ref_type=heads which is common utility for both. This looks even stronger reason to just merge this with gitlab.
Like mentioned earlier, gitaly can run on a different machine - sometimes there can be multiple gitaly nodes all controlled by a single gitlab service.
Attachment:
OpenPGP_0x8F53E0193B294B75.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature