[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: golang-google-grpc + golang-github-google-s2a-go



Hello

Le lun. 12 févr. 2024 à 21:49, Simon Josefsson <simon@josefsson.org> a écrit :
Simon Josefsson <simon@josefsson.org> writes:

> Further progress on grpc.  I've rebuilt 1.60.1 with some EXCLUDE fixes
> thanks to help on irc, we've gone from 22 reverse build failures down to
> 16 failures, here is the pipeline:
>
> https://salsa.debian.org/jas/golang-google-grpc/-/pipelines/629139

Getting grpc into unstable is going to be some work...

Today I worked on one of the failures above:
golang-github-grpc-ecosystem-go-grpc-prometheus.  With new grpc it fail
like this:

https://salsa.debian.org/jas/golang-google-grpc/-/jobs/5191066

=== RUN   TestNativeErrorUnwrapping
    grpcstatus1.13+_test.go:24:
...
                                -  Message: (string) (len=16) "Userspace error.",
                                +  Message: (string) (len=85) "go native wrapped error: rpc error: code = FailedPrecondition desc = Userspace error.",

Building the version we have in unstable including reverse dependencies:

https://salsa.debian.org/jas/golang-github-grpc-ecosystem-go-grpc-prometheus/-/pipelines/638044

All good -- ignoring failures in cadvisor, crowdsec,
gitlab-ci-multi-runner due to
https://lists.debian.org/debian-go/2024/01/msg00128.html and
golang-github-katalix-go-l2tp due to
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063746

Lacking a better fix, I patched out the failing self-test since it seems
related to error message string mismatches, and I lack the Go skills to
come up with a better fix.  Upstream seems gone, the project is
archived, so I didn't file a upstream bug report.  I fixed some other
small packaging nits too.  Changes here:

golang-github-grpc-ecosystem-go-grpc-prometheus should be deprecated in debian as well, and replaced by
https://github.com/grpc-ecosystem/go-grpc-middleware

First move is to report a RC-bug on that package, so it gets removed from testing if no one steps in.
Second move is to start packaging go-grpc-middleware...

Jérémy

Reply to: