[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Advice on vendoring for new package golang-github-uber-jaeger-client-go



On Fri, 2023-08-04 at 12:58 +0800, Shengjing Zhu wrote:
> 
> I didn't see lxd imports github.com/uber/jaeger-client-go. Did I miss something?

  The dependency tree looks like this:

  LXD
    github.com/grafana/dskit (ITP #1001989)
      github.com/weaveworks/common (ITP #1001982)
        github.com/uber/jaeger-client-go

> We can also exclude thrift related code, if it's not needed by lxd. We
> don't need to package all things.

  I haven't fully looked into this, but maybe that could be a way forward.

Mathias

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: