Re: Upload request: dnss (version 0.0~git20220702.0.de3cc4ff-1)
On Sun, Jul 03, 2022 at 11:44:21AM +0530, Nilesh Patra wrote:
On 7/2/22 9:39 PM, Alberto Bertogli wrote:
Hi!
I updated package dnss (https://salsa.debian.org/go-team/packages/dnss) to the current upstream, since it's been > 2y since the last one, and some important changes have gone in since then.
There were no changes needed to the Debian package, it was just a sync with upstream.
Can someone please review the changes and upload?
Please let me know if you have any questions or comments!
Can't generate tarball,
| $ gbp buildpackage
| gbp:error: Can not find pristine tar commit for archive 'dnss_0.0~git20220702.0.de3cc4ff.orig.tar.xz'
For future reference, we talked about this on IRC.
This was due to Nilesh accidentally having pristine-tar=true in their
gbp.conf.
| $ origtargz
| Trying uscan --download --download-current-version ...
| uscan warn: In debian/watch no matching hrefs for version 0.0~git20220702.0.de3cc4ff in watch line
| https://github.com/albertito/dnss/tags .*/v?(\d\S+)\.tar\.gz
| Could not find any location for dnss_0.0~git20220702.0.de3cc4ff.orig.tar.*
Can you fix this?
I did my best to fix this in
https://salsa.debian.org/go-team/packages/dnss/-/commit/c8e36e0493b5de876f64bc2eb9c0b64b53dd037e.
I don't think it's great but it's what I could come up.
For the next release I'd love to make `upstream` the same branch as
actual upstream/master, that would bring it in line with other packages
I work with and remove the need for these kinds of overrides, and have a
cleaner history in the Debian master branch too.
We can also switch from "<date>.0.<commit>" to the newer
"<date>.<commit>" too.
But I don't know if doing that will break any Debian tools.
We also discussed a test failure in Nilesh' environment (but worked fine
on mine and in Salsa CI), that has been fixed upstream [1].
Thank you!
Alberto
[1]: https://blitiri.com.ar/git/r/dnss/c/79e7e85a562a3b87a2ab08fb551fa226e10f13d1/
Reply to: