[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1003090: RFS: ffcvt/1.7.5-1



Hi Tong,

On 1/16/22 10:41 PM, Tong Sun wrote:
I'll remove the build dependency of easygen as planned, as I know for
sure it can fix the issue
I am not sure if that's the problem here. Why would it fix the issue?

[...]
config.go:1:1: expected 'package', found 'EOF'

which is in turn caused by
https://salsa.debian.org/go-team/packages/ffcvt/-/blob/master/debian/rules#L20

that
rm -f ... config.go
statement.
I know removing the build dependency of easygen will work because I
don't need to do `rm -f ... config.go` after that.

Apparently not.
I tried doing these changes on a different branch[1], but as you might see, the CI is still
failing[2], unless I did that wrong. So it is likely unrelated.
I think the the config.go that you see there is _probably_ this one[3] instead of the one in package, because
this thing is being 'run'.

I took this even further I triggered salsa CI on a branched-off commit from _last uploaded version_ of ffcvt
see here[4] and that still fails, while that has nothing to do with easygen at all.

The CI is trying to build all golang packages, install your current package and trying to test if something failed
after installing current package. Since ffcvt has no reverse-deps and no deps either, it looks highly unlikely for
it to break anything at all.
It seems a problem with the CI instead here. I do think we can ignore CI failures here.

(I'll remove these useless branches before uploading the new release.)

[1]: https://salsa.debian.org/go-team/packages/ffcvt/-/commits/salsa-ci
[2]: https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2372473
[3]: https://salsa.debian.org/go-team/infra/pkg-go-tools/-/blob/master/config/config.go
[4]: https://salsa.debian.org/go-team/packages/ffcvt/-/commits/salsa-ci-test

Everything builds fine locally, even with sbuild --
https://paste.debian.net/1227301/
That's why I don't understand why it fails in salsa CI, even after
I've done a brand new push to salsa --
https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2372315

Yep. I faced a failure on another package of mine today that does nothing intrusive at all[5]
and it goes fine on buildd[6] so IMO we ignore this for now. CI doesn't work perfect for all packages (which is fine too)

[5]: https://salsa.debian.org/go-team/packages/golang-github-biogo-graph/-/jobs/2371800
[6]: https://buildd.debian.org/status/fetch.php?pkg=golang-github-biogo-graph&arch=all&ver=0.0%7Egit20150317.057c198-3&stamp=1642331568&raw=0
@Alois, could you shed some light on the CI thingy?
  From the logs, it is hard to figure out what went wrong.
The packages that are shown failing there do not have anything to do with ffcvt package, are the failing logs stored somewhere?
> Yes please @Alois.

CC'ed Faust as well. @Faustin, would you have some idea?
Hope that helps. Let me know if you need sponsoring.
Please do when all dust settles.

I want to do this now, but I'll wait for a couple of days for replies/opinions.

Yes, indeed Nilesh, as I'm not allowed to do dput myself yet.

Have you sorted out your gpg key stuff?
If yes, you should be able to upload after this month's keyring changes (hopefully next week)

Regards,
Nilesh


Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: