[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1003090: RFS: ffcvt/1.7.5-1



Hi Tong,

On 1/15/22 2:55 AM, Tong Sun wrote:
Hi,

The situation should have been fixed with the new upload of easygen.

However, the CI build is still failing in salsa. This is something
that I don't understand as it builds OK on github.

Sorry I've run out of ideas why it is happening like this, and am now
thinking to remove the build dependency of easygen, to fix this and to
make things easier...

I still don't have a clue why

I intended to reply earlier, but I was occupied and simply forgot later, sorry about that!

it builds OK on github but fails in
salsa CI build, and I still hope that somebody can help.

Okay, so there are two parts to it.

1) Why does github CI pass?
Ok, so there are two reasons about this as well
 + test-all.sh does not seem to run anywhere in your github actions/CI and that error stems from this script (in the deb package)
 + `go test -v` in your CI essentially does nothing since there are no _test.go files and it is visible
    on the CI too

| go test -v ./...
|  shell: /usr/bin/bash -e {0}
|  env:
|    GOROOT: /opt/hostedtoolcache/go/1.15.15/x64
| github.com/suntong/ffcvt
| ?   	github.com/suntong/ffcvt	[no test files]

So you probably should update it accordingly there as well.

2) For salsa CI, I thought that it is because of the failing build.
You will find the build failure logs pasted at the end of this email.
The reason for test to be failing is that you have not updated "test/ffcvt_test.txt" file in accordance with the
latest manpage/latest ffcvt options upstream.

However, even after I have pushed a patch to fix the build, salsa CI chokes.

@Alois, could you shed some light on the CI thingy?
From the logs, it is hard to figure out what went wrong.
The packages that are shown failing there do not have anything to do with ffcvt package, are the failing logs stored somewhere?

I'll wait for one or two weeks more, and if still nobody can help,

It is usually a good idea to ask on #debian-mentors if there is more delay in a reply.
Also, feel free to ping me if you think I can be of any help.

I'll remove the build dependency of easygen as planned, as I know for
sure it can fix the issue
I am not sure if that's the problem here. Why would it fix the issue?

Somebody help please.

Hope that helps. Let me know if you need sponsoring.

Regards,
Nilesh


| cd obj-x86_64-linux-gnu/src/github.com/suntong/ffcvt/test && ./test-all.sh
| ffcvt
| Version 1.7.5 built on 2022-01-02
| - Test (config.go) cli help output
| - Test transcoding single file
| - Test -sym control
| - Compare test results
| --- ffcvt_test.txt	2022-01-15 07:35:05.137033394 +0000
| +++ /tmp/ffcvt_test.txt	2022-01-15 07:35:08.193097895 +0000
| @@ -6,3 +6,3 @@
|
| -  -t	target type: webm/x265-opus/x264-mp3/youtube (FFCVT_T)
| +  -t	target type: webm/x265-opus/x264-mp3/wx/youtube/copy (FFCVT_T)
|   -ves	video encoding method set (FFCVT_VES)
| @@ -32,3 +32,8 @@
|   -vss	video: same size (FFCVT_VSS)
| +  -C,Cut	Cut segment(s) out to keep. Specify in the form of start-[end],
| +	strictly in the format of hh:mm:ss, and may repeat (FFCVT_C,CUT)
| +  -S,Seg	Split video into multiple segments (strictly in format: hh:mm:ss) (FFCVT_S,SEG)
| +  -Speed	Speed up/down video playback speed (e.g. 1.28) (FFCVT_SPEED)
|   -lang	language selection for audio stream extraction (FFCVT_LANG)
| +  -sel	subtitle encoding language (language picked for reencoded video) (FFCVT_SEL)
|   -o	more options that will pass to ffmpeg program (FFCVT_O)
| @@ -49,2 +54,14 @@
|
| +  -C value
| +    	Cut segment(s) out to keep. Specify in the form of start-[end],
| +    		strictly in the format of hh:mm:ss, and may repeat
| +  -Cut value
| +    	Cut segment(s) out to keep. Specify in the form of start-[end],
| +    		strictly in the format of hh:mm:ss, and may repeat
| +  -S string
| +    	Split video into multiple segments (strictly in format: hh:mm:ss)
| +  -Seg string
| +    	Split video into multiple segments (strictly in format: hh:mm:ss)
| +  -Speed string
| +    	Speed up/down video playback speed (e.g. 1.28)
|   -abr string
| @@ -90,2 +107,4 @@
|   -p	par2create, create par2 files (in work directory)
| +  -sel value
| +    	subtitle encoding language (language picked for reencoded video)
|   -sep string
| @@ -99,3 +118,3 @@
|   -t string
| -    	target type: webm/x265-opus/x264-mp3/youtube (default "webm")
| +    	target type: webm/x265-opus/x264-mp3/wx/youtube/copy (default "webm")
|   -vc
| 1

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: