Re: [RFS] golang-github-antlr-antlr4
On 29 July 2021 5:32:04 pm IST, Peymaneh Nejad <p.nejad@posteo.de> wrote:
>
>Am 29.07.21 um 10:26 schrieb Nilesh Patra:> I don't know what version
>the
>dependency chain needs, but the closer to
>> antlr4 source (I think this is at 4.7.2 or something) the better.
>>
>> Would you consider doing this?
>
>github.com/google/cel-go builds fine with 4.7.2 and tests are also
>passing.
>
>However, with 4.7.2. the go runtime is not thread-safe, which was fixed
>in
>v4.9.0 with this PR[1].
>
>This does not concern google/cel-go, they have fixed the issue on their
>side[2]
>and afaik there is currently no other package depending on
>golang-github-antlr-antlr4, but I assume it would be good to have it
>backported
>in the debian package if I package 4.7.2, right?
Yes, you could apply the commit as a patch in d/patches
>I have not looked into it but the changes[2] seem to be very small
That should be fine by all means. Thanks for spotting this!
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Reply to: