[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS/package review



Am 08.06.21 um 12:17 schrieb Nilesh Patra:
On 6/8/21 3:20 PM, Peymaneh Nejad wrote:
I have packaged two dependencies for caddy, maybe someone wants to have a look at them?

first is golang-github-masterminds-goutils:
https://salsa.debian.org/go-team/packages/golang-github-masterminds-goutils/-/commits/debian/sid

i don't have the rights to change the default salsa branch to debian/sid, hence the odd link. maybe someone with the proper rights can do that?
I am also not sure if I can/should tidy up the obsolete branches like master, pristine-tar and so on and how to deal with the "upstream" branch: it is not a tracking branch of the upstream code and therefore my local upstream branch would get rejected..

How did you import it?
For me this seems to work just fine

$ uscan -dd
$ gbp import-orig ../golang-github-masterminds-goutils_1.1.1.orig.tar.gz
$ git checkout upstream
$ git log --oneline | head -1
c1da3a2 New upstream version 1.1.1

Once you fix the debian/sid branch and inline it with upstream, I'll remove master and pristine-tar after verifying locally that your changes work ofcourse

Thanks for showing me through! I initially tried gpg import-orig but not correctly as I now see, and eventually just used origtargz..

I believe debian/sid is fixed now. The commit history is not too pretty but I assumed that'd better than reverting and force-pushing my last commits

second is golang-github-masterminds-sprig:
https://salsa.debian.org/go-team/packages/golang-github-masterminds-sprig

the latter depends on the first, and it also depends on a recent version of golang-github-masterminds-semver-dev which unfortunately is in the repos but not the needed version.
For now I have feild a bug (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989594)
and did a quick (& a bit dirty) fork so one could test the build until this is resolved:
https://salsa.debian.org/peymaneh/golang-github-masterminds-semver-dev/-/commits/master/

Fair enough. I suppose we can upload golang-github-masterminds-semver-dev version 3.x.y to experimental for the moment, and you do all your work by pulling this from experimental. What say?

Okay. I have changed the respective changelogs to experimental

Another small question regarding the two packages: I have omitted the "upstream-contact"-field in d/copyright because> 1. I couldn't find one and

In such cases, you can simply link to the issue tracker of that repo as upstream contact. That's a way of reaching upstream developers too, right?
See here for example: https://salsa.debian.org/go-team/packages/golang-github-brentp-irelate/-/blob/debian/sid/debian/copyright#L3

2. saw that some other packages also did not include the field.

That doesn't sound very convincing ;-P

Lintian didn't complain but I am still not sure if this is correct.

Righto. See above :-)

Thanks! Fixed

Let me know if you have any confusion still

Nilesh





Reply to: