[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Updating golang-github-gin-gonic-gin to 1.6.3



Hi,

As discussed earlier[1], I'd like to get golang-github-gin-gonic-gin
updated to a newer version.

 1. https://lists.debian.org/debian-go/2020/12/msg00019.html

For that, a bunch of packages are needed, namely:
 - golang-github-gin-gonic-gin 1.6.3-1
 - golang-github-go-playground-assert-v2 2.0.1-1
 - golang-github-go-playground-locales 0.13.0-1
 - golang-github-go-playground-universal-translator 0.17.0-1
 - golang-github-go-playground-validator-v10 10.4.1-1
 - golang-github-leodido-go-urn 1.2.0-1

(List slightly updated to reflect keeping the /v2 and /v10 part of two
packages, turning that into -v2 and -v10 in package names.)

The dependency chain is as follows:
 - golang-github-gin-gonic-gin
    → golang-github-go-playground-validator-v10
 - golang-github-go-playground-validator-v10
    → golang-github-go-playground-assert-v2
    → golang-github-go-playground-locales
    → golang-github-go-playground-universal-translator
    → golang-github-leodido-go-urn-dev
 - golang-github-go-playground-universal-translator
    → golang-github-go-playground-locales

My initial proof-of-concept packages have been cleaned up over the last
few days (thanks to the awesome feedback I received on the list), and
have been uploaded to NEW. Meanwhile, they are also available in a
custom repository, accessible this way:

    deb     [trusted=yes] https://crowdsec.apt.debamax.com uploaded-to-new main
    deb-src [trusted=yes] https://crowdsec.apt.debamax.com uploaded-to-new main

(I could add GPG signing if that's desired.)


Now, looking at olang-github-gin-gonic-gin, I've noticed it used to be
repacked because of some examples, but those were moved to a separate
repository, so that doesn't seem to be required anymore. I've adjusted
the packaging enough for it to seem decent to me, and that can be seen
in its repository on Salsa, in the pu/master branch (I didn't want to be
pushing anything to master itself before it has had a chance to be
reviewed, that's one of the first existing packages I'm touching).

It would probably make sense to get upstream to make the test socket
location configurable instead of keeping the patch for us only; and we
should probably unlink the socket after use anyway. Stashing it under
_build/ makes it go away via `debian/rules clean` which makes it a small
problem only.


Using ratt gave rather good results, meaning only 3 FTBFSes across the
35 detected packages (full list at the bottom of the mail):
 - consul_1.0.7~dfsg1-5
 - rkt_1.30.0+dfsg1-9
 - singularity-container_3.5.2+ds1-1

The first one seemed a bit strange because #964873 seemed fixed a while
ago. It turned out that's another case of an old source package in
unstable (1.0.7~dfsg1-5 while the most recent is 1.8.6+dfsg1-1).

I've switched to wondering why the most recent version wouldn't be
picked up until I noticed that Build-Depends changed quite a lot between
1.0.7~dfsg1-5 and 1.8.6+dfsg1-1. In particular, this one disappeared:
golang-github-fsouza-go-dockerclient-dev; and it's built by one of the
source packages that appeared earlier in the list built by ratt:
golang-github-fsouza-go-dockerclient. So I think it's pretty normal
that the most recent consul package doesn't get picked up.

Meanwhile:
 - rkt; known FTBFS without change (#964871)
 - singularity-container: ditto (#978441)

So in the end, it looks to me it might be safe to update the
golang-github-gin-gonic-gin package once all dependencies have
cleared NEW.

I'm happy to perform whatever extra tests, or refine my initial work if
required, to help get the upgrade on track.


Contents of buildlogs/ (I can share any files on demand):

    acbuild_0.4.0+dfsg-3
    alertmanager-irc-relay_0.2.0-1
    aptly_1.4.0+ds1-2
    cfrpki_1.1.4-3
    consul_1.0.7~dfsg1-5
    docker.io_20.10.0+dfsg2-1
    docker-registry_2.7.1+ds2-7
    gitlab-ci-multi-runner_13.3.1+dfsg-3
    golang-github-appc-docker2aci_0.17.2+dfsg-2
    golang-github-bugsnag-bugsnag-go_1.7.0-1
    golang-github-containers-buildah_1.16.6+dfsg1-2
    golang-github-containers-common_0.26.3+ds1-2
    golang-github-containers-image_5.8.1-3
    golang-github-deanthompson-ginpprof_0.0~git20201112.007b1e5-1
    golang-github-fsouza-go-dockerclient_1.6.6-1
    golang-github-gin-contrib-cors_1.3.1-1
    golang-github-gin-contrib-gzip_0.0.3-1
    golang-github-gin-contrib-static_0.0~git20200916.d45d9a3-1
    golang-github-mcuadros-go-gin-prometheus_0.1.0+git20190723.c7374e9-3
    golang-github-openshift-imagebuilder_1.1.6-2
    golang-github-optiopay-kafka_2.1.1-1
    golang-github-rs-cors_1.7.0-2
    golang-github-samalba-dockerclient_0.0~git20160531.0.a303626-2
    golang-github-shopify-logrus-bugsnag_0.0~git20171204.577dee2-2
    golang-github-tonistiigi-fsutil_0.0~git20200331.f427cf1-2
    golang-github-ulule-limiter_3.3.3-1
    libpod_2.1.1+dfsg1-3
    nomad_0.10.9+dfsg1-1
    nomad-driver-podman_0.1.0-1
    notary_0.6.1~ds2-6
    prometheus_2.22.0+ds-1
    prometheus-alertmanager_0.21.0+ds-2
    rkt_1.30.0+dfsg1-9
    singularity-container_3.5.2+ds1-1
    skopeo_1.2.0+dfsg1-2


Cheers,
-- 
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/

Attachment: signature.asc
Description: PGP signature


Reply to: