Hi, Still cleaning up my initial proof-of-concepts for several packages, I thought I'd ask about this one particular thing I've hit once or twice: `dh-make-golang` detects the need for this package in Build-Depends and Depends: golang-x-text-dev. while there's no such package. It seems I should be replacing that package with golang-golang-x-text-dev, because: - Dropping golang-x-text-dev only leads to an FTBFS in a clean chroot (see error message below). - Replacing golang-x-text-dev with golang-golang-x-text-dev seems to be doing the trick just fine. - It seems this could be due to “Extra-Source-Only: yes” entries for an old golang-x-text package in unstable's Source file (see below). According to https://tracker.debian.org/pkg/golang-x-text it was removed in August 2020 (replaced by golang-golang-x-text, see #964921). Therefore, I'm wondering whether dh-make-golang might be confused by two source packages declaring the same Go-Import-Path, and whether we should help it pick the right one by implementing a golang-x-text-dev vs. golang-golang-x-text-dev test there. In hindsight, it would be even better to ignore all entries with E-S-O: yes, and we wouldn't have to special-case this specific transition. For the records, E-S-O: yes is a flag that's used to keep source packages in the archive for license compliance reasons, usually because packages are listed in Built-Using. See below for an excerpt of unstable's Sources, focusing on packages that advertise golang.org/x/text in their Go-Import-Path. FTBFS excerpt: src/github.com/go-playground/locales/cmd/generate_resources.go:15:2: cannot find package "golang.org/x/text/unicode/cldr" in any of: /usr/lib/go-1.15/src/golang.org/x/text/unicode/cldr (from $GOROOT) /build/golang-github-go-playground-locales-0.13.0/_build/src/golang.org/x/text/unicode/cldr (from $GOPATH) Sources excerpt: Package: golang-golang-x-text Binary: golang-golang-x-text-dev Version: 0.3.2-3 Go-Import-Path: golang.org/x/text Extra-Source-Only: yes Package: golang-golang-x-text Binary: golang-golang-x-text-dev Version: 0.3.2-4 Go-Import-Path: golang.org/x/text Extra-Source-Only: yes Package: golang-golang-x-text Binary: golang-golang-x-text-dev Version: 0.3.3-1 Go-Import-Path: golang.org/x/text Extra-Source-Only: yes Package: golang-golang-x-text Binary: golang-golang-x-text-dev Version: 0.3.4-1 Go-Import-Path: golang.org/x/text Package: golang-x-text Binary: golang-golang-x-text-dev, golang-x-text-dev Version: 0.0~git20170627.0.6353ef0-1 Go-Import-Path: golang.org/x/text Extra-Source-Only: yes Package: golang-x-text Binary: golang-golang-x-text-dev, golang-x-text-dev Version: 0.3.0-2 Go-Import-Path: golang.org/x/text Extra-Source-Only: yes Package: golang-x-text Binary: golang-golang-x-text-dev, golang-x-text-dev Version: 0.3.2-1 Go-Import-Path: golang.org/x/text Extra-Source-Only: yes which means 3 first “right package, wrong version”, 1 “right package, right (current) version”, 3 “wrong package”. Cheers, -- Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/
Attachment:
signature.asc
Description: PGP signature