[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: uTLS -- Fork of the Go standard TLS library



(Please keep debian-go@ in cc)

On Tue, Feb 18, 2020 at 7:34 PM 石博文 <sbw@sbw.so> wrote:
>
> Hi. I have re-create package with dh-make-golang, and upload to [1].
>
> [1] https://salsa.debian.org/sbw-guest/golang-github-refraction-networking-utls/
>

Maybe you forget to push?

Or maybe dh-make-golang is not smart enough to do right.
Could you try to run latest dh-make-golang[1].
And run `dh-make-golang make -type=l github.com/refraction-networking/utls`

Some notable problems are:
1. since it's library, the binary package name should be `xx-dev`, and
arch is all.
2. test is disabled, please try best to run the tests, or give a clear
reason in the comments
3. debian/watch file is incorrect for project which has no tag.

Some minor issues:
3. use debhelper-compat = 12 to simplify the code
4. Standards-Version is outdated.
5. some template files are not deleted
...

I think most issues could be fixed if you create the package with
dh-make-golang.

And please run lintian[2] after the package is built.

[1] The one in unstable or built from https://github.com/Debian/dh-make-golang
[2] https://tracker.debian.org/pkg/lintian, and run with
    lintian -EvIL +pedantic *.changes

-- 
Shengjing Zhu


Reply to: