[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#945215: ITP: golang-github-census-instrumentation-opencensus-proto -- Language Independent Interface Types For OpenCensus



On Thursday, 21 November 2019 11:56:58 PM AEDT Arnaud Rebillout wrote:
> https://salsa.debian.org/go-team/packages/golang-github-census-instrumentat
> ion-opencensus-proto
> 
> which is needed to build
> 
> https://salsa.debian.org/go-team/packages/golang-github-census-ecosystem-op
> encensus-go-exporter-ocagent

Awesome. Thanks.
It would be very nice to mention URL of the Salsa repository in ITP.

For ITPs I recommend to set metadata properly such as 

    block 945216 by 945215

(because one new package depends on another)


> which is needed to build Azure/go-autorest v13.3.0

Therefore I would do the following:

    bts affects 945216 src:golang-github-azure-go-autorest


Few corrections are needed to prepare the first package for upload:

1. correct short package description in regards to capitalization

2. Pre-built binary ".jar" file should be removed from the source archive

3. All generated files must be re-built from source

Merely setting "DH_GOLANG_GO_GENERATE:=1" is not enough as there will be 
FTBFS if you remove pre-built files before build (always a good idea to 
ensure a build integrity):

~~~~
override_dh_clean:
<------>dh_clean
<------>-find . -type f -name '*.pb.go' -delete -printf 'removed %p\n'
~~~~

Upstream build .pb.go files by "src/mkgogen.sh" which is not invoked on 
build...


Thanks.

-- 
Cheers,
 Dmitry Smirnov.

---

Success is not final, failure is not fatal: it is the courage to continue
that counts.
        -- Winston Churchill


Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: