Re: RFS: easygen 3.0 & golang-github-go-easygen-easygen-dev
Thanks a lot Dawid! will change tonight...
On Wed, Mar 20, 2019 at 1:56 PM Dawid Dziurla <dawidd0811@gmail.com> wrote:
>
> This patch should do the trick:
>
> diff --git a/debian/rules b/debian/rules
> index 4566daf..fe59661 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -23,7 +23,7 @@ export SHELL=/bin/bash
> override_dh_auto_install:
> dh_auto_install # -- --no-source
> dh_install -p$(BINPKG) usr/bin/easygen
> - dh_install -p$(LIBPKG) usr/share/gocode
> + dh_install -p$(LIBPKG) --exclude=test/.gitignore usr/share/gocode
>
> # override_dh_clean:
> # rm -rf man
>
> śr., 20 mar 2019 o 17:45 Tong Sun <suntong001@users.sourceforge.net> napisał(a):
> >
> > On Wed, Mar 20, 2019 at 12:40 PM Dawid Dziurla <dawidd0811@gmail.com> wrote:
> > >
> > > Hello,
> > >
> > > I just successfully built your package and the only warnings I got
> > > from lintian were:
> > > - binary-without-manpage usr/bin/easygen
> > > - package-contains-vcs-control-file
> > > usr/share/gocode/src/github.com/go-easygen/easygen/test/.gitignore
> >
> > thanks a lot for the review Dawid.
> >
> > For the man page. I'm working on it, besides other major changes down
> > the road. so let's skip it this time.
> >
> > For the, package-contains-vcs-control-file, how can I remove that file
> > from the source?
> >
> > thx
> >
> > > Also, you can easily generate manpage with help2man utlity.
> > >
> > > śr., 20 mar 2019 o 16:45 Tong Sun a):
> > > >
> > > > Dear Go team,
> > > >
> > > > I am looking for (help and) a sponsor for the package "easygen" at
> > > > https://salsa.debian.org/go-team/packages/easygen
> > > >
> > > > The package was tested on both gbp and sbuild.
> > > > It's also lintian-clean, with the following known issues:
> > > >
> > > > - no man page. I'm working on it, besides other major changes down the road
> > > > - the statically-linked-binary error, which deemed OK by Florian. Details below.
> > > >
> > > > Could you please reviewing/sponsoring this?
> > > >
> > > > Any kind of reviews and suggestions are appreciated.
> > > >
> > > >
> > > > On Wed, Mar 20, 2019 at 5:55 AM Florian Weimer wrote:
> > > > >
> > > > > * Tong Sun:
> > > > >
> > > > > > On Wed, Mar 20, 2019 at 5:43 AM Florian Weimer wrote:
> > > > > >
> > > > > >> > I've upload the package "easygen" to
> > > > > >> > https://salsa.debian.org/go-team/packages/easygen
> > > > > >> >
> > > > > >> > It is still having the above statically-linked-binary problem.
> > > > > >
> > > > > >> This is a Go binary which does not link with glibc, only with the Go
> > > > > >> runtime. There is no technical problem with that, it's the preferred
> > > > > >> method of building such applications. ...
> > > > > >>
> > > > > >> I think the lintian check needs to be improved. There was already a
> > > > > >> bug about it:
> > > > > >
> > > > > > Oh, thanks for looking into it and the confirmation Florian!
> > > > > >
> > > > > > I'll submit a formal RFS letter later. Or, if you find no other
> > > > > > issues with it, would you sponsor me please?
> > > > >
> > > > > Sorry, I'm not a Go package maintainer (and I'm barely a Debian
> > > > > developer these days).
> > > >
Reply to: