[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Ability to only run certain "go generate" commands in dh-golang



I opened an issue upstream [1] and they have already prepared a fix for it.  Thanks for the great suggestion!

Stephen

[1] https://github.com/git-lfs/git-lfs/issues/3473

> On Jan 9, 2019, at 11:09 AM, Stephen Gelman <ssgelm@debian.org> wrote:
> 
> Oh, that's a good question.  I can look into that more and file an upstream PR.
> 
> Stephen
> 
> On Wed, Jan 9, 2019 at 9:26 AM Shengjing Zhu <zhsj@debian.org> wrote:
>> 
>> On Tue, Jan 8, 2019 at 11:47 AM Stephen Gelman <ssgelm@debian.org> wrote:
>>> 
>>> Hi,
>>> 
>>> Currently, with dh-golang, the only configuration option for running “go generate” is DH_GOLANG_GO_GENERATE which is all or nothing.  With git-lfs, one of the “go generate” commands it runs is windows-specific
>> 
>> Probably this is bug in upstream, but I haven't digged into the code.
>> 
>> `go generate` should respect build tags. Why this command is not in
>> file which has `+build windows` tag?
>> 
>> 
>> --
>> Shengjing Zhu


Reply to: