[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#929195: ITP: golang-github-bradfitz-iter -- Range over integers [0,n). Seriously, that's it.



On 2019-05-19 18:23, Drew Parsons wrote:
On 2019-05-19 17:45, Bastian Blank wrote:
On Sun, May 19, 2019 at 03:12:01PM +0800, Drew Parsons wrote:
This package was intended to be an educational joke when it was
released in in 2014. People didn't get the joke part and started
depending on it. That's fine, I guess. (This is the Internet.) But
it's kinda weird. It's one line, and not even idiomatic Go style. I
encourage you not to depend on this or write code like this, but I do
encourage you to read the code and think about the representation of
Go slices and why it doesn't allocate.

Please merge this code into the using one.


It's used quite extensively by the anacrolix Go packages (missinggo,
tagflag), it would be messy to replace every single instance.

Unless we can get them to put it in missinggo/iter/n.go


H Bastion, following up on your objection to the Go micropackage golang-github-bradfitz-iter, I did file a bug uptream at
https://github.com/anacrolix/missinggo/issues/15

Curiously, upstream supports keeping it as a separate module, citing upstream tests in the micromodule that ensure it keeps working properly. But that's more about keeping the test working than the actual function. Does it mean upstream is just lazy?

Drew


Reply to: