Re: [dh-make-golang][Solution]

[Utkarsh Gupta <guptautkarsh2102@gmail.com>]

Hey,

[Removing d-devel]

On 13/05/19 12:10 am, Raman Tehlan wrote:

Hello,

I have created both a library and a tool to get a recursive list of all the golang dependencies which are or are not yet packaged in Debian, I am addressing this [issue](https://github.com/Debian/dh-make-golang/issues/89), for which I create my solution [here](https://github.com/ramantehlan/GoCheckDeb).

Once I have the feedback from the community, I will make the pull request to implement it in the official project [here](https://github.com/Debian/dh-make-golang)

I got the time to look at it and explore the features it has and came across a couple of things, which are as follows:

I tried looking up the dependencies of lazygit via all the options available and got different results.
   a. via graph: https://paste.debian.net/1090346/
   b. via map: https://paste.debian.net/1090345/
   c. via list: https://paste.debian.net/1090347/
   
Also, it shows "(No Deb Package)" for packages that are actually packaged and are available on tracker.debian.org. I am not sure if I am missing something, am I?
On the other hand, it should actually reflect the output of dh-make-golang's estimate command.
That appears to work perfectly for me, like the --recursive way Raju mentioned on that issue.

Another thing I noticed is that for various projects, for instance, micro, it throws an error: https://paste.debian.net/1090348/ :(


Here's a quick inspection (Jongmin Kim did):

I think the main problem is GoCheckDeb tries import path with full depth (even sub-directories).
It should check if lazygit is packaged or not, but not lazygit/pkg/config, lazygit/pkg/utils, lazygit/vendor/..
Same for golang.org/x/text. While it should check if it is packaged or not, it also checks for golang.org/x/text/language, which I think is not necessary, or is it?

I am not sure if I am missing something that is obvious? Or the above reports are correct.
Please let me know what you think :)



Best,
Utkarsh

Attachment: signature.asc
Description: OpenPGP digital signature