Bug#910125: dh-golang: DH_GOLANG_INSTALL_EXTRA does not preserve file permissions
Package: dh-golang
Version: 1.36
Severity: normal
When using DH_GOLANG_INSTALL_EXTRA to install some test fixtures in
https://github.com/hashicorp/go-slug I noticed that one of the files has
an execute bit that is not preserved, causing the test to fail. This
seems to be caused by dh-golang using "copy" instead of "cp". From
http://perldoc.perl.org/File/Copy.html:
You may use the syntax use File::Copy "cp" to get at the cp alias
for this function. The syntax is exactly the same. The behavior is
nearly the same as well: as of version 2.15, cp will preserve the
source file's permission bits like the shell utility cp(1) would do,
while copy uses the default permissions for the target file (which
may depend on the process' umask, file ownership, inherited ACLs,
etc.).
Testing locally switching to "cp" fixed my issue and I don't know of any
cases where it would break things. I'm planning on submitting a MR to
fix this but I wanted to make sure a bug was created to track this.
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.18.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages dh-golang depends on:
ii debhelper 11.4.1
ii dpkg 1.19.1
ii libdpkg-perl 1.19.1
ii perl 5.26.2-7
dh-golang recommends no packages.
dh-golang suggests no packages.
-- no debconf information
Reply to: