[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1053241: marked as done (glibc: please apply upstream patch to fix slow fstat)

Your message dated Sat, 11 May 2024 22:36:07 +0200
with message-id <Zj_WtyN_PRhRtI6L@aurel32.net>
and subject line Re: Bug#1053241: glibc: please apply upstream patch to fix slow fstat
has caused the Debian Bug report #1053241,
regarding glibc: please apply upstream patch to fix slow fstat
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1053241: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053241
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: glibc
Version: 2.36-9+deb12u1
Severity: normal
X-Debbugs-Cc: pedretti.fabio@gmail.com

Dear Maintainer,

glibc uses a slow version of fstat. Details are documented
here: https://lwn.net/Articles/944214/

A patch to fix this was merged in glibc:
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=551101e8240b7514fc646d1722f8b79c90362b8f

The patch applies cleanly and builds fine also on bookworm glibc.
Please consider apply it to fix slow fstat.

Thanks.

--- End Message ---
--- Begin Message --- 
Version: 2.39-1

On 2023-11-26 18:19, Fabio Pedretti wrote:
> Il giorno dom 26 nov 2023 alle ore 16:28 Aurelien Jarno
> <aurel32@debian.org> ha scritto:
> >
> > Hi,
> >
> > On 2023-09-29 21:52, Fabio Pedretti wrote:
> > > Package: glibc
> > > Version: 2.36-9+deb12u1
> > > Severity: normal
> > > X-Debbugs-Cc: pedretti.fabio@gmail.com
> > >
> > > Dear Maintainer,
> > >
> > > glibc uses a slow version of fstat. Details are documented
> > > here: https://lwn.net/Articles/944214/
> > >
> > > A patch to fix this was merged in glibc:
> > > https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=551101e8240b7514fc646d1722f8b79c90362b8f
> > >
> > > The patch applies cleanly and builds fine also on bookworm glibc.
> > > Please consider apply it to fix slow fstat.
> >
> > This patch changes the syscall used by binaries, so it has to be
> > considered with a lot of care in a stable release, it could break
> > existing seccomp filters. In any case it has to live a few months in
> > testing/unstable first.
> >
> > Note that the kernel patch that improves the performance of fstatat, has
> > not been merge to the upstream stable tree, nor to bookworm.
> >
> > In order to better understand the need for this patch in bookworm, could
> > you please give some details about your workload and the performance
> > impact it has?
> 
> I did some test with my use case, borg backup with many unchanged
> files, see https://github.com/borgbackup/borg/issues/4498 for some
> background and system calls impact, where borg 1.2 slow downs a lot
> vs. borg 1.1.
> 
> I checked using strace the patch, it did the job (newfstatat calls
> were replaced with fstat), and I'd hoped that it would improve
> performance, however my use case improved just marginally (difficult
> to have reproducible data in my case, but it was like 5%).
> 
> I didn't notice any other regression, however.
> 
> I see the glibc patch is still only on 2.39, while even Debian
> experimental has just 2.38.

Debian experimental now has version 2.39, closing the bug accordingly.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

--- End Message ---
Reply to: