[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861183: [PATCH] redact the build directory out of the glibc-source tarball paths

On 2017-04-25 15:46, Andrew Shadura wrote:
> Package: glibc-source
> Version: 2.24-10
> Severity: important

I fail to see why it is an important bug, IMHO it should be minor or

> Tags: patch
> Control: affects -1 cross-toolchain-base
> X-Debbugs-Cc: Aurelien Jarno <aurelien@aurel32.net>
> Hi,
> We’re building a downstream distribution based on Debian using OBS, and
> it unpacks packages differently than Debian buildds do.

I guess you don't use the default directory created by dpkg-source.

> When the tarball for glibc-source package is being created, the
> directory name where the package is unpacked may be captured by tar and
> embedded into the tarball paths. On its own it may cause further
> inconvenience when unpacking the tarball, but quite a practical downside
> of that is that one of the Debian packages in affected by
> this: cross-toolchain-base fails to unpack glibc tarball, or more
> precisely, unpacks it into a different directory compared to what it
> expects, and the build fails.
> This patch mitigates this issue, replacing the glibc-source tarball path
> prefix with glibc-$(GLIBC_VERSION) using tar’s --xform option.

Thanks for the patch, it looks fine. That said I guess we actually avoid
adding the unpack directory to GLIBC_SOURCES and transforming that.

I'll look at that when applying the patch, after the freeze.

Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Attachment: signature.asc
Description: PGP signature

Reply to: