[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832521: Please backport fix for O_TMPFILE for jessie



On 2016-07-26 15:10, Michael Biebl wrote:
> Source: glibc
> Version: 2.19-18+deb8u4
> Severity: normal
> Tags: patch
> 
> Hi,

Hi,

> while working on a backport of systemd v230 for jessie, we ran into
> issues. Our test-suite was failing on i386, specifically test-tmpfiles.
> It turns out, the files created wit O_TMPFILE had broken permissions and
> were unreadable. After further investigation, this turned out to be a
> bug in glibc[2].
> I've backported the commit to 2.19 and with that patch applied, our
> test-suite completed successfully on i386. The patch I've attached did
> compile successfully on i386 and it fixed our issue in systemd. There
> where a few conflicts when cherry-picking the patch, so please
> double-check, just in case I missed something.

The conflicts concerns file which have been moved out of the ports/
directory. The changes to generic/open.c and generic/open64.c should
therefore be applied to these files on the ports directory. There are
used by arm64 so we also want the bug to be fixed there.

I'll get the bug fixed by backporting this commit to the upstream 2.19
stable branch, and then pull this branch in the debian package.

> It would be great if you could include this patch in your next stable
> upload. I noticed that there is already an accepted upload
> 2.19-18+deb8u5 for jessie 8.6. It would be awesome if you could make a
> follow-up upload 2.19-18+deb8u6 to get that fix into 8.6 (I think there
> is still some time left for that). If not, please consider including it
> for 8.7.

I am still doing tests for other fixes we have pending, I expect to open
a bug report against release.debian.org for an upload to stable in the
next days. If it get accepted, that should be in time for 8.6.

> The commit itself has been in unstable/stretch for a while, so seen some
> wider testing.

Indeed, and the fix looks straightforward and easily reviewable.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net


Reply to: