[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#635192: provide O_CLOEXEC on kfreebsd-*



On Fri, May 31, 2013 at 02:04:06PM +0200, Julien Cristau wrote:
> On Mon, May 13, 2013 at 09:43:48 +0200, Petr Salinger wrote:
> 
> > Hi.
> > 
> > Both wheezy kernels (8.3 and 9.0) do support O_CLOEXEC.
> > Together with enabling O_CLOEXEC we have to
> > at least raise minimal kernel version to 8.3 in
> > 
> >   debian/debhelper.in/libc.preinst
> >   debian/sysdeps/kfreebsd.mk
> > 
> > We have to wait before buildd receives new kernel,
> > as current (squeezy one) does not suffice.
> > 
> I don't understand why this is taking so long.  O_CLOEXEC was defined on
> Linux long before all supported kernels had it, and people (used to?)
> have fallback code for the case where open(O_CLOEXEC) returned EINVAL,

That's exactly the point, most of the fallback code has been removed.

> to do the racy fcntl dance.  I don't see why the kernel running on
> buildds matters one bit for whether userland gets the define...
> 

Anyway this has just been done, so it's now just a matter of days.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net


Reply to: