Re: "struct user" conflicts on arm
On Sat, Dec 17, 2011 at 7:54 PM, peter green <plugwash@p10link.net> wrote:
>> Your patch to fix ucontext namespace pollution looks good, please post
>> that to libc-ports for review
>
> should I send it immidiately or should I wait until I have test results to
> give them?
Wait until the test results are complete and you've built gdb, this
allows your patch to be accepted immediately if the maintainers agree
that it's a good thing.
>> and make sure to state what testing
>> you've done with the patch. At a minimum you should run the glibc
>> testsuite
>
> Afaict the debian packaging automatically runs the testsuite and compares it
> against
> a list of expected failures (ideally that list would be empty but in real
> life....).
Upstream wants to know that no new failures appeared with your patch.
>> and build gdb with those newly installed headers.
>
> Will do once I get glibc built and installed, are there any specific tests
> you want doing with gdb or is testing it still builds sufficient??
In this case I think building gdb is sufficient.
However, the strongest case would be made by showing no regressions in
the gdb testsuite with and without your glibc patch.
Cheers,
Carlos.
Reply to: