[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#652356: please use argument-safe bswap macros on all architectures

Jonathan Nieder dixit:

>There are kinder ways to say that.


>Thorsten, can you test this patch or arrange for it to be tested?

Will do that once the next buildhost gets idle (one is currently
building gcc-4.6 (second upload in one day), the other working
its something off to build a kernel with gcc-4.6, to see whether
we can switch that there as well).

(At the patch: huh… I’d have used ({ instead of static inline,
plus didn’t know __builtin_constant_p works even like that. But
if it works, sure, why not.)

Sometimes they [people] care too much: pretty printers [and syntax highligh-
ting, d.A.] mechanically produce pretty output that accentuates irrelevant
detail in the program, which is as sensible as putting all the prepositions
in English text in bold font.	-- Rob Pike in "Notes on Programming in C"

Reply to: