Bug#629556: also getosreldate()
On Sat, Jun 18, 2011 at 07:25:45PM +0200, Robert Millan wrote:
> 2011/6/18 Aurelien Jarno <aurelien@aurel32.net>:
> > I start to wonder if all these functions have really their place in
> > the GNU libc, as they are quite FreeBSD specific, while the functions
> > there are supposed to functions common to all OS. Maybe it's the time to
> > revive a specific freebsd library?
>
> I agree. But then why was libfreebsd merged into glibc?
We merged only some parts of it, the things that seems to be used
widely. Other parts where implemented directly in freebsd-utils or
freebsd-libs.
> > Alternatively couldn't we have these directly in the NFS userland code?
>
> Which functions are you referring to? getvfsbyname and getosreldate
> are not related to NFS (and getosreldate() is used in many places, I even
> had to implement a replacement in GRUB).
getosreldate is indeed use in various userland tools and probably has
its place in the glibc. The other seems to be used only in NFS, one
being clearly NFS specific.
The thing is that when you add a new function to glibc, you can never
remove it (at least not until the libc7 transition). We should not add
new functions just because it's the easiest way to port code, but
because it's the best way to do it. I am not fully convince for some of
the functions that you want to add there.
> >> getosreldate() also needed by NFS userland code
> >> (both fixes are in SVN).
> >
> > Please revert that (or leave them disabled). Whatever the decision,
> > we have to handle that with the 2.14 upload for versioning reasons.
>
> Which functions should be removed/disabled? We have:
All of them. You can't add new functions at a random time, it has to be
coordinated to a new version (2.14 in this case) to nt break symbol
versioning.
OTOH we do want to make some changes that do not break the ABI from the
glibc-bsd SVN. Adding the new functions now means we can't do that any
more until version 2.14. And we do have fixes pending there.
This has to be either removed or disabled, committed in a different
branch, or provided as a patch (for example glibc-2.14.patch) in the
glibc-ports. We usually use the latter solution.
> Two userland functions (not NFS specific):
>
> getosreldate
> getvfsbyname
>
> Two syscall stubs:
>
> nfssvc
> nlm_syscall
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
Reply to: