[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#516755: marked as done (tzdata: race condition when updating /etc/localtime)

Your message dated Mon, 27 Apr 2009 13:32:09 +0000
with message-id <E1LyQwL-0004dc-7B@ries.debian.org>
and subject line Bug#516755: fixed in tzdata 2009g-1
has caused the Debian Bug report #516755,
regarding tzdata: race condition when updating /etc/localtime
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
516755: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=516755
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: tzdata
Version: 2009b-1
Severity: minor
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch jaunty

Hello!

The postinst updates /etc/localtime:

        # Update the timezone
        echo $AREA/$ZONE > /etc/timezone
        rm -f /etc/localtime && \
            cp -f /usr/share/zoneinfo/$AREA/$ZONE /etc/localtime

This has some minor problems:

 * If the cp fails for some reason, then you do not have any
   /etc/localtime at all.

 * There is a tiny race condition between the rm and the cp, which
   can lead to log files showing wrong timestamps.

I propose to use something atomic and more robust, such as:

        # Update the timezone
        echo $AREA/$ZONE > /etc/timezone
        cp -f /usr/share/zoneinfo/$AREA/$ZONE /etc/localtime.dpkg-new && \
	    mv -f /etc/localtime.dpkg-new /etc/localtime

Thank you for considering!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: tzdata
Source-Version: 2009g-1

We believe that the bug you reported is fixed in the latest version of
tzdata, which is due to be installed in the Debian FTP archive:

tzdata-java_2009g-1_all.deb
  to pool/main/t/tzdata/tzdata-java_2009g-1_all.deb
tzdata_2009g-1.diff.gz
  to pool/main/t/tzdata/tzdata_2009g-1.diff.gz
tzdata_2009g-1.dsc
  to pool/main/t/tzdata/tzdata_2009g-1.dsc
tzdata_2009g-1_all.deb
  to pool/main/t/tzdata/tzdata_2009g-1_all.deb
tzdata_2009g.orig.tar.gz
  to pool/main/t/tzdata/tzdata_2009g.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 516755@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Clint Adams <schizo@debian.org> (supplier of updated tzdata package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 27 Apr 2009 09:15:36 -0400
Source: tzdata
Binary: tzdata tzdata-java
Architecture: source all
Version: 2009g-1
Distribution: unstable
Urgency: low
Maintainer: GNU Libc Maintainers <debian-glibc@lists.debian.org>
Changed-By: Clint Adams <schizo@debian.org>
Description: 
 tzdata     - time zone and daylight-saving time data
 tzdata-java - time zone and daylight-saving time data for use by java runtimes
Closes: 516755
Changes: 
 tzdata (2009g-1) unstable; urgency=low
 .
   [ Aurelien Jarno ]
   * postinst: fix race condition when updating /etc/localtime. Closes:
     bug#516755.
 .
   [ Clint Adams ]
   * New upstream version.
Checksums-Sha1: 
 0ef478b20423b44cc23e011fb12e27c40bf04fcc 1127 tzdata_2009g-1.dsc
 16cbad6e5305b60fcb8e9fd27caed7ee403053ef 178279 tzdata_2009g.orig.tar.gz
 e3feb8f1bf2da90c3216bd6fa19e531a8c3e9173 217075 tzdata_2009g-1.diff.gz
 a118694dde17c5d0ee8676c77687acaa7cf2e9bf 758614 tzdata_2009g-1_all.deb
 ce48126b37449705741a4a4900149e32a37e6bbe 148570 tzdata-java_2009g-1_all.deb
Checksums-Sha256: 
 4b2ab06f8d8681c66f965547fca10805751f2721762bb3df360266637ed5fa46 1127 tzdata_2009g-1.dsc
 7f225409c58481b84b3463deb05f4fae6b57b77d04c074a0d4857c8fd8f70a8d 178279 tzdata_2009g.orig.tar.gz
 6a94f13ff74d9150d870840698e29ace8719fc9e14f8aaf8721dedc3861a82e2 217075 tzdata_2009g-1.diff.gz
 d0990d627f60df894b236c6f96ef4a0277454ea5764a7696de9f8dc196d3dbec 758614 tzdata_2009g-1_all.deb
 66dab8153f5b6f6b3c244dbb0fa945e27e5eb2115c4eecd6394bb133c8104ee9 148570 tzdata-java_2009g-1_all.deb
Files: 
 d3471216c34c2fa82f588d8744f25fac 1127 libs required tzdata_2009g-1.dsc
 71d5b94d04c33f18dcc0b42df2383299 178279 libs required tzdata_2009g.orig.tar.gz
 ae0bf795315c4feae933e90947479724 217075 libs required tzdata_2009g-1.diff.gz
 d162429736ae4493d0fb04a4709e0914 758614 libs required tzdata_2009g-1_all.deb
 01e3166c285187b6483249c66bfab5dc 148570 java optional tzdata-java_2009g-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Debian!

iD8DBQFJ9bCj5m0u66uWM3ARAl1eAKC8MiATCdLEVrhP+6WxwDJe0TJvtwCghtGp
Y5SucZLee+yMkCMBwLoOurc=
=JWGJ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: