[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#381905: linux-kernel-headers: NGROUPS_MAX doesn't match the kernel and causes test failures



Gabor Gombas wrote:
On Mon, Aug 07, 2006 at 11:43:07AM -0600, Vladislav Yasevich wrote:

It is important to specify proper limits for this.  This is a request to set
NGROUPS_MAX to 65535, so it matches the kernel, in linux-kernel-headers
package.

As already said, there is no way a fixed constant (NGROUPS_MAX) can
match a value that can change during run-time. LTP should not use
NGROUPS_MAX but use sysconf(_SC_NGRPOUPS_MAX) instead, which does The
Right Thing(tm).

LTP does use sysconf. The problem really is glibc in Sarge using a compiled-in value from <linux/limits.h>. However, after talking with
Jeff Bailey, I realized that changing the value in limits.h will only
fix things for 2.6.8 kernel, but break it for 2.4 series which is still
supported in Sarge. It also doesn't address the possibility of users building their own kernels.

Another possibility is to backport some of the changes from glibc 2.4 that uses the /proc interface for these sysconf calls to get the values from the currently running kernel. This would fix things once and for all, but this might be too invasive for Sarge to accept.

-vlad


Gabor





Reply to: