[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#361039: marked as done (libc6: bad regcomp initialization, fixed upstream)

Your message dated Thu, 6 Apr 2006 12:05:49 -0600
with message-id <20060406180549.GA10951@mmjgroup.com>
and subject line Bug#361039: libc6: bad regcomp initialization, fixed upstream
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: libc6
Severity: serious
Version: 2.3.6-4


After initializing a mutex, regcomp zeros the structure.  On
architectures that have non-zero free lock values (e.g., hppa) this
results in deadlock.

The following patch fixes the problem.
(See http://www.sourceware.org/cgi-bin/cvsweb.cgi/libc/posix/regcomp.c.diff?r1=1.95&r2=1.96&cvsroot=glibc )

===================================================================
RCS file: /cvs/glibc/libc/posix/regcomp.c,v
retrieving revision 1.95
retrieving revision 1.96
diff -u -r1.95 -r1.96
--- libc/posix/regcomp.c	2005/05/06 23:33:52	1.95
+++ libc/posix/regcomp.c	2005/07/10 22:01:14	1.96
@@ -774,8 +774,6 @@
     }
   preg->used = sizeof (re_dfa_t);
 
-  __libc_lock_init (dfa->lock);
-
   err = init_dfa (dfa, length);
   if (BE (err != REG_NOERROR, 0))
     {
@@ -789,6 +787,8 @@
   strncpy (dfa->re_str, pattern, length + 1);
 #endif
 
+  __libc_lock_init (dfa->lock);
+
   err = re_string_construct (&regexp, pattern, length, preg->translate,
 			     syntax & RE_ICASE, dfa);
   if (BE (err != REG_NOERROR, 0))
===================================================================

--- End Message ---
--- Begin Message --- 
On Thu, Apr 06, 2006 at 09:10:41AM +0200, Aurelien Jarno wrote:
> Are you sure of the version against which you reported the bug? This 
> patch is present in the package since the version 2.3.6-4. With it I was 
> able to run the testsuite again.

Sorry - I was given to understand that it was still present in -4.  As
opposed to etch. :-(

not a bug in sid.

lamont

--- End Message ---
Reply to: