Re: Bug#347545: login crashes when trying to use nis

[Denis Barbier <barbier@linuxfr.org>]

On Thu, Jan 12, 2006 at 12:19:15AM +0000, Mark Brown wrote:
[...]
> You should find that the set of instructions which is provided
> /usr/share/doc/nis/nis.debian.howto.gz is sufficient to configure most
> systems - if you have found any major omissions in there please do let
> me know.  Users do get explicitly referred to that document when they
> first install the package although they aren't prompted during a
> dpkg-reconfigure run.

Thanks to Mark's explanations in this file, I have been able to reproduce
this bug.  The attached patch should fix it, I will test tonight and take
the liberty to commit it, this patch is trivial and harmless.

About #345641, can I assume that webmin needs to be restarted too, or do
we have to wait for a reply from the bug submitter?

Denis

This assertion breaks applications if they redefine malloc/free functions,
malloc_usable_size may then report wrong values.  This is true for instance
with bash, whereas bash-static works fine because it does not use its own
wrapper functions.  See #322011 and merged bugs.

# DP: Dpatch author: Denis Barbier
# DP: Patch author: Denis Barbier
# DP: Upstream status: BZ692
# DP: Date: 2006-01-12


Index: glibc-2.3.5/nis/nss_nis/nis-netgrp.c
===================================================================
--- glibc-2.3.5.orig/nis/nss_nis/nis-netgrp.c
+++ glibc-2.3.5/nis/nss_nis/nis-netgrp.c
@@ -76,7 +76,10 @@
 	 and the last byte is filled with NUL.  So we can simply
 	 use that buffer.  */
       assert (len > 0);
-      assert (malloc_usable_size (netgrp->data) >= len + 1);
+      /* Call to malloc_usable_size disabled, this breaks if applications
+	 redefine malloc/free with a different implementation.
+	 This assert is always true, see yp_match.  */ 
+      /* assert (malloc_usable_size (netgrp->data) >= len + 1);*/
       assert (netgrp->data[len] == '\0');
 
       netgrp->data_size = len;