[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#274289: marked as done (locales: postinst should not overwrite settings in /etc/environment)



Your message dated Mon, 7 Nov 2005 22:35:55 +0100
with message-id <20051107213555.GB8223@linuxfr.org>
and subject line Bug#274289: Downgrading severity
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 30 Sep 2004 20:38:22 +0000
>From asp16@alu.ua.es Thu Sep 30 13:38:22 2004
Return-path: <asp16@alu.ua.es>
Received: from 84-120-70-21.onocable.ono.com (chistera.yi.org) [84.120.70.21] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CD7gx-0000MJ-00; Thu, 30 Sep 2004 13:38:21 -0700
Received: from userid 1000 by chistera.yi.org with local (Exim 4.34) 
	  id 1CD7gj-0001gQ-37
	  for submit@bugs.debian.org; Thu, 30 Sep 2004 22:38:05 +0200
Date: Thu, 30 Sep 2004 22:38:04 +0200
From: Adeodato =?iso-8859-1?Q?Sim=F3?= <asp16@alu.ua.es>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: locales: postinst should not overwrite settings in /etc/environment
Message-ID: <20040930203804.GA6293@chistera.yi.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="2fHTh5uZTiUOsy+g"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Reportbug-Version: 2.99.4
X-No-CC: Please respect my Mail-Followup-To header
X-Debbugs-CC: Denis Barbier <barbier@linuxfr.org>
User-Agent: Mutt/1.5.6+20040907i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-9.8 required=4.0 tests=BAYES_00,FROM_ENDS_IN_NUMS,
	HAS_PACKAGE,X_DEBBUGS_CC autolearn=ham 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--2fHTh5uZTiUOsy+g
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Package: locales
Version: 2.3.2.ds1-17
Severity: wishlist

  [setting severity to wishlist as per GOTO Masanori's request. I would
  have gone for a much higher one, though.]

  problem: locales.postinst overwrites the LANG setting in
  /etc/environment in each upgrade, making it impossible to manually
  maintain it.

  though it should *never* modify it, one would expect *at* *least*, for
  it to remain untouched if the answer to "default_environment_locale"
  is "None" (which is my case). currently is not the case: with "None"
  as an answer, the LANG seting in $EE gets deleted.

  quoting Michael Tokarev in #274208:

    [...] debconf database is only a cache for configuration questions,
    and should NOT be used to STORE the config info, which, if needed,
    should be retrieved from actual config files [...] during upgrade.

  I would expect at least the attached patch to be applied to
  locales.postinst (minimal patch, just to express what I mean; could be
  done better).

  thanks,

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.7-1-686
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8

Versions of packages locales depends on:
ii  debconf                     1.4.38       Debian configuration management sy
ii  libc6 [glibc-2.3.2.ds1-17]  2.3.2.ds1-17 GNU C Library: Shared libraries an

-- debconf information:
* locales/default_environment_locale: None

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
The difference between literature and journalism is that journalism is
unreadable and literature is not read.
                -- Oscar Wilde

--2fHTh5uZTiUOsy+g
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="postinst.diff"

--- locales.postinst.old	2004-09-30 22:34:26.000000000 +0200
+++ locales.postinst	2004-09-30 22:36:57.000000000 +0200
@@ -56,11 +56,11 @@
     if [ -e $EE ]; then
         sed -e '/^ *LANG=/d' $EE > $EE.tmp || true
         #  $EE has to be updated if $SELECTED is empty or 'None'
-        cp -f $EE.tmp $EE
     else
         :> $EE.tmp
     fi
     if [ -n "$SELECTED" ] && [ "$SELECTED" != "None" ]; then
+        cp -f $EE.tmp $EE
         #   Add a newline in case last line does not have one
         echo >> $EE.tmp
         echo "LANG=$SELECTED" >> $EE.tmp

--2fHTh5uZTiUOsy+g--


---------------------------------------
Received: (at 274289-done) by bugs.debian.org; 7 Nov 2005 20:40:10 +0000
>From barbier@mp4h.org Mon Nov 07 12:40:10 2005
Return-path: <barbier@mp4h.org>
Received: from main.uucpssh.org [212.27.33.224] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EZDmk-0004wy-00; Mon, 07 Nov 2005 12:40:10 -0800
Received: from localhost (localhost [127.0.0.1])
	by main.uucpssh.org (Postfix) with ESMTP id 84FA48E896
	for <274289-done@bugs.debian.org>; Mon,  7 Nov 2005 21:40:09 +0100 (CET)
Received: by main.uucpssh.org (Postfix, from userid 10)
	id 32B4A8E8FD; Mon,  7 Nov 2005 21:40:09 +0100 (CET)
Received: by localhost.localdomain (Postfix, from userid 1000)
	id 79CD247DBF; Mon,  7 Nov 2005 22:35:55 +0100 (CET)
Date: Mon, 7 Nov 2005 22:35:55 +0100
From: Denis Barbier <barbier@linuxfr.org>
To: 274289-done@bugs.debian.org
Subject: Re: Bug#274289: Downgrading severity
Message-ID: <20051107213555.GB8223@linuxfr.org>
References: <20041218075818.GA8274@linuxfr.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041218075818.GA8274@linuxfr.org>
User-Agent: Mutt/1.5.11
Delivered-To: 274289-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

On Sat, Dec 18, 2004 at 08:58:18AM +0100, I wrote:
> > From what I understand, the libc6 postinst blindly overwrites
> > /etc/environment's LANG setting, whether the user changed it or not.
> [...]
> > Therefore, Steven set the severity to serious.
> 
> Wrong assumption, downgrading severity.
> If your /etc/environment is really modified by locales.postinst, please
> send this file so that we can see what's going on.

No news for months, closing this bug now.
Thanks for your report.

Denis



Reply to: