[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#334119: Patch to prevent open_not_cancel etc. from being inlined; needed for Plash's modified glibc



Daniel Jacobowitz <drow@false.org> wrote:

> > Having looked into this, one problem is that it won't work with the
> > "libc" and "nptl" builds of glibc that Debian does, because these use
> > "int $0x80" directly.  It would only work with the "i686" build.  So
> > this won't work with Linux 2.4 or with pre-686 processors.
> 
> Correct.  It wouldn't anyway; Linux 2.4 did not have a vsyscall.

>From my reading of the code, glibc will use a vsyscall entry point if
AT_SYSINFO is defined in the auxv, and this doesn't necessarily
require Linux 2.6.


> > As an alternative, I could build Plash from the NPTL build of glibc:
> > the relevant calls are already not inlined.  That would involve
> > changing the patch to put the NPTL object files into libc6-pic
> > instead.  But it would require Linux 2.6.
> 
> Huh?  Then why did your patch need to modify NPTL?

NPTL inlines some but not all of the not-cancel.h calls.  I didn't
need them all un-inlined, but for completeness I un-inlined all of
them, in case I needed to replace these calls in the future.

Mark



Reply to: