Bug#111767: syslog.h bug persists

[GOTO Masanori <gotom@debian.or.jp>]

At Sat, 5 Mar 2005 13:32:48 +0000,
Richard Kettlewell wrote:
> GOTO Masanori writes:
> > Neil Spring wrote:
> 
> >> 2.2.5-14.3 still has the sys/syslog.h SYSLOG_NAMES bug.
> >> 
> >> it'd be great if someone can apply:
> >> 
> >> -   char    *c_name;
> >> +   const char  *c_name;
> >> 
> >> or report it upstream.  
> >> 
> >> I realize there are bigger problems to deal with; thanks for
> >> your hard work.
> > 
> > This report and proposed patch was rejected by upstream.  Upstream
> > explained that if we fix with this kind of patch for removing
> > -Wwrite-strings warnings, some user programs (which don't use const
> > char) start compilation warnings.
> 
> It is never safe to write to a string literal so there is no advantage
> to them in treating them as non-const.  I think those programs should
> be fixed instead of imposing this bug on correct programs.

I understand your opinion.  Please read the following discussion:

	http://sources.redhat.com/ml/libc-alpha/2005-02/msg00062.html

> > SYSLOG_NAMES is used for obsolete purpose,

AFAIK koders shows only some programs use it:

	http://www.koders.com/?s=SYSLOG_NAMES&_%3Abtn=Search&_%3Ala=*&_%3Ali=*

> Please can you say what we should use instead?

I don't say you shouldn't use it.

Regards,
-- gotom