Bug#111767: marked as done (syslog.h produces warnings with gcc -Wwrite-strings -DSYSLOG_NAMES)
Your message dated Sat, 05 Mar 2005 14:09:07 +0900
with message-id <81vf8665n0.wl@omega.webmasters.gr.jp>
and subject line Bug#111767: syslog.h bug persists
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 9 Sep 2001 13:38:40 +0000
>From richard@lyonesse.greenend.org.uk Sun Sep 09 08:38:40 2001
Return-path: <richard@lyonesse.greenend.org.uk>
Received: from chiark.greenend.org.uk [195.224.76.132] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 15g4nH-0007Ue-00; Sun, 09 Sep 2001 08:38:39 -0500
Received: from (sfere.relativity.greenend.org.uk) [172.18.45.1] (mail)
by chiark.greenend.org.uk with esmtp (Exim 3.12 #2)
id 15g4nG-0003mE-00 (Debian); Sun, 09 Sep 2001 14:38:38 +0100
Received: from lyonesse.relativity.greenend.org.uk [172.18.45.66] (mail)
by sfere.relativity.greenend.org.uk with esmtp (Exim 3.12 #1 (Debian))
id 15g4nB-0000lE-00; Sun, 09 Sep 2001 14:38:33 +0100
Received: from richard by lyonesse.relativity.greenend.org.uk with local (Exim 3.31 #1 (Debian))
id 15g4nB-0000kP-00; Sun, 09 Sep 2001 14:38:33 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <87iteslc12.fsf@rjk.greenend.org.uk>
Date: Sun, 9 Sep 2001 14:38:33 +0100
X-Face: h[Hh-7npe<<b4/eW[]sat,I3O`t8A`(ej.H!F4\8|;ih)`7{@:A~/j1}gTt4e7-n*F?.Rl^
F<\{jehn7.KrO{!7=:(@J~]<.[{>v9!1<qZY,{EJxg6?Er4Y7Ng2\Ft>Z&W?r\c.!4DXH5PWpga"ha
+r0NzP?vnz:e/knOY)PI-
X-Boydie: NO
From: Richard Kettlewell <rjk@greenend.org.uk>
To: submit@bugs.debian.org
Subject: syslog.h produces warnings with gcc -Wwrite-strings -DSYSLOG_NAMES
X-Mailer: VM 6.92 under 21.4 (patch 1) "Copyleft" XEmacs Lucid
Sender: Richard Kettlewell <richard@lyonesse.greenend.org.uk>
Delivered-To: submit@bugs.debian.org
Package: libc6-dev
Version: 2.2.4-1
This patch to <sys/syslog.h> adds the missing "const".
ttfn/rjk
--- sys/syslog.h.orig Sun Sep 9 14:27:58 2001
+++ sys/syslog.h Sun Sep 9 14:28:28 2001
@@ -67,8 +67,8 @@
/* mark "facility" */
#define INTERNAL_MARK LOG_MAKEPRI(LOG_NFACILITIES, 0)
typedef struct _code {
- char *c_name;
- int c_val;
+ const char *c_name;
+ int c_val;
} CODE;
CODE prioritynames[] =
---------------------------------------
Received: (at 111767-done) by bugs.debian.org; 5 Mar 2005 05:09:09 +0000
>From gotom@debian.or.jp Fri Mar 04 21:09:09 2005
Return-path: <gotom@debian.or.jp>
Received: from omega.webmasters.gr.jp (webmasters.gr.jp) [218.44.239.78]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D7RXJ-0005IO-00; Fri, 04 Mar 2005 21:09:09 -0800
Received: from omega.webmasters.gr.jp (localhost [127.0.0.1])
by webmasters.gr.jp (Postfix) with ESMTP
id 9E473DEB1E; Sat, 5 Mar 2005 14:09:07 +0900 (JST)
Date: Sat, 05 Mar 2005 14:09:07 +0900
Message-ID: <81vf8665n0.wl@omega.webmasters.gr.jp>
From: GOTO Masanori <gotom@debian.or.jp>
To: Richard Kettlewell <rjk@greenend.org.uk>,
Neil Spring <nspring@cs.washington.edu>, 111767-done@bugs.debian.org
Subject: Re: Bug#111767: syslog.h bug persists
In-Reply-To: <20020919025241.GB19756@cs.washington.edu>
References: <20020919025241.GB19756@cs.washington.edu>
User-Agent: Wanderlust/2.9.9 (Unchained Melody) SEMI/1.14.3 (Ushinoya)
FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2
(i386-debian-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya")
Content-Type: text/plain; charset=US-ASCII
Delivered-To: 111767-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
At Wed, 18 Sep 2002 19:52:47 -0700,
Neil Spring wrote:
> 2.2.5-14.3 still has the sys/syslog.h SYSLOG_NAMES bug.
>
> it'd be great if someone can apply:
>
> - char *c_name;
> + const char *c_name;
>
> or report it upstream.
>
> I realize there are bigger problems to deal with; thanks for
> your hard work.
This report and proposed patch was rejected by upstream. Upstream
explained that if we fix with this kind of patch for removing
-Wwrite-strings warnings, some user programs (which don't use const
char) start compilation warnings. SYSLOG_NAMES is used for obsolete
purpose, and it's not well used these days, so their argument seems
one of accountable opinion for me. Well, I think there're various
opinions, so you could discuss with it to upstream.
I close this bug.
Regards,
-- gotom
Reply to: