[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#325460: marked as done (glibc: Fails to notice build failures due to | tee)

Your message dated Fri, 14 Oct 2005 17:05:19 -0700
with message-id <E1EQZY7-0007YA-00@spohr.debian.org>
and subject line Bug#325460: fixed in glibc 2.3.5-7
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 28 Aug 2005 20:24:36 +0000
>From brederlo@informatik.uni-tuebingen.de Sun Aug 28 13:24:36 2005
Return-path: <brederlo@informatik.uni-tuebingen.de>
Received: from mx4.informatik.uni-tuebingen.de [] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1E9Thj-0008NB-00; Sun, 28 Aug 2005 13:24:35 -0700
Received: from localhost (loopback [])
	by mx4.informatik.uni-tuebingen.de (Postfix) with ESMTP
	id B286B1255; Sun, 28 Aug 2005 22:24:03 +0200 (DFT)
Received: from mx4.informatik.uni-tuebingen.de ([])
 by localhost (mx4 []) (amavisd-new, port 10024) with ESMTP
 id 13974-01; Sun, 28 Aug 2005 22:24:02 +0200 (DFT)
Received: from localhost.localdomain (semeai.Informatik.Uni-Tuebingen.De [])
	by mx4.informatik.uni-tuebingen.de (Postfix) with ESMTP
	id 506691191; Sun, 28 Aug 2005 22:24:01 +0200 (DFT)
Received: from mrvn by localhost.localdomain with local (Exim 4.50)
	id 1E9Th0-0007Ar-O0; Sun, 28 Aug 2005 22:23:51 +0200
Content-Type: multipart/mixed; boundary="===============6469208009415311323=="
MIME-Version: 1.0
From: Goswin Brederlow <brederlo@informatik.uni-tuebingen.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: glibc: Fails to notice build failures due to | tee
X-Mailer: reportbug 3.9
Date: Sun, 28 Aug 2005 22:23:50 +0200
Message-Id: <E1E9Th0-0007Ar-O0@localhost.localdomain>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

This is a multi-part MIME message sent by reportbug.

Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: glibc
Severity: normal
Tags: patch


while patching around glibc I noticed that certain errors don't stop
the build process, those with '| tee' constructs. The attached patch
adds a makro that logs the output while preserving the retrun code of
the command being run.


-- System Information:
Debian Release: 3.1
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.8-frosties-2
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="patch1"

diff -u glibc-2.3.5/debian/rules.d/build.mk glibc-2.3.5/debian/rules.d/build.mk
--- glibc-2.3.5/debian/rules.d/build.mk
+++ glibc-2.3.5/debian/rules.d/build.mk
@@ -3,6 +3,15 @@
 # This little bit of magic makes it possible:
 xx=$(if $($(curpass)_$(1)),$($(curpass)_$(1)),$($(1)))
+# We want to log output to a logfile but we also need to preserve the
+# return code of the command being run.
+# This little bit of magic makes it possible:
+# $(call logme, [-a] <log file>, <cmd>)
+define logme
+(exec 3>&1; exit `( ( ( $(2) ) 2>&1 3>&-; echo $$? >&4) | tee $(1) >&3) 4>&1`)
 $(patsubst %,mkbuilddir_%,$(GLIBC_PASSES)) :: mkbuilddir_% : $(stamp)mkbuilddir_%
 $(stamp)mkbuilddir_%: $(stamp)patch-stamp $(LINUX_HEADER_DIR)
 	@echo Making builddir for $(curpass)
@@ -42,21 +57,22 @@
 	    echo "No.  Forcing cross-compile by setting build to $$configure_build."; \
 	  fi; \
 	fi; \
-	cd $(DEB_BUILDDIR) && \
+	$(call logme, -a $(log_build), \
+		cd $(DEB_BUILDDIR) && \
 		CC="$(call xx,CC)" \
 		AUTOCONF=false \
 		$(CURDIR)/$(DEB_SRCDIR)/configure \
 		--host=$(call xx,configure_target) \
 		--build=$$configure_build --prefix=/usr --without-cvs \
 		--enable-add-ons="$(call xx,add-ons)" --without-selinux \
-		$(call xx,with_headers) $(call xx,extra_config_options) 2>&1 | tee -a $(log_build)
+		$(call xx,with_headers) $(call xx,extra_config_options))
 	touch $@
 $(patsubst %,build_%,$(GLIBC_PASSES)) :: build_% : $(stamp)build_%
 $(stamp)build_%: $(stamp)configure_%
 	@echo Building $(curpass)
-	$(MAKE) -C $(DEB_BUILDDIR) -j $(NJOBS) 2>&1 | tee -a $(log_build)
+	$(call logme, -a $(log_build), $(MAKE) -C $(DEB_BUILDDIR) -j $(NJOBS))
 	touch $@
 $(patsubst %,check_%,$(GLIBC_PASSES)) :: check_% : $(stamp)check_%
@@ -71,7 +87,7 @@
 	  echo "Testsuite disabled for $(curpass), skipping tests."; \
 	else \
 	  echo Testing $(curpass); \
-	  $(MAKE) -C $(DEB_BUILDDIR) -j $(NJOBS) -k check 2>&1 | tee -a $(log_test); \
+	  $(call logme, -a $(log_test), $(MAKE) -C $(DEB_BUILDDIR) -j $(NJOBS) -k check) \
 	touch $@


Received: (at 325460-close) by bugs.debian.org; 15 Oct 2005 00:10:43 +0000
>From rmurray@spohr.debian.org Fri Oct 14 17:10:43 2005
Return-path: <rmurray@spohr.debian.org>
Received: from rmurray by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1EQZY7-0007YA-00; Fri, 14 Oct 2005 17:05:19 -0700
From: Daniel Jacobowitz <dan@debian.org>
To: 325460-close@bugs.debian.org
X-Katie: lisa $Revision: 1.30 $
Subject: Bug#325460: fixed in glibc 2.3.5-7
Message-Id: <E1EQZY7-0007YA-00@spohr.debian.org>
Sender: Ryan Murray <rmurray@spohr.debian.org>
Date: Fri, 14 Oct 2005 17:05:19 -0700
Delivered-To: 325460-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 5

Source: glibc
Source-Version: 2.3.5-7

We believe that the bug you reported is fixed in the latest version of
glibc, which is due to be installed in the Debian FTP archive:

  to pool/main/g/glibc/glibc-doc_2.3.5-7_all.deb
  to pool/main/g/glibc/glibc_2.3.5-7.diff.gz
  to pool/main/g/glibc/glibc_2.3.5-7.dsc
  to pool/main/g/glibc/libc6-amd64_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-dbg_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-dev-amd64_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-dev_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-i686_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-pic_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-prof_2.3.5-7_i386.deb
  to pool/main/g/glibc/libc6-udeb_2.3.5-7_i386.udeb
  to pool/main/g/glibc/libc6_2.3.5-7_i386.deb
  to pool/main/g/glibc/libnss-dns-udeb_2.3.5-7_i386.udeb
  to pool/main/g/glibc/libnss-files-udeb_2.3.5-7_i386.udeb
  to pool/main/g/glibc/locales_2.3.5-7_all.deb
  to pool/main/g/glibc/nscd_2.3.5-7_i386.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 325460@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Daniel Jacobowitz <dan@debian.org> (supplier of updated glibc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Fri, 14 Oct 2005 14:18:22 -0400
Source: glibc
Binary: libc6-dev-amd64 libc6-i686 libc6-dev-ppc64 libc0.3-pic glibc-doc libc1-udeb libc0.3 libc6.1-dev libc1-pic libc6-s390x libnss-files-udeb libc1-dbg libc6-dev-sparc64 libc0.3-dev libc6-udeb libc6-dbg libc6.1-pic libc6-dev libc0.3-prof libc6-sparcv9 libc6.1-prof libc1 locales libc6-pic libc0.3-udeb libc1-prof libc6-ppc64 libc0.3-dbg libc6-amd64 libc6-prof libc6 libc6-sparcv9b libc6.1-udeb libc6.1-dbg nscd libc6-sparc64 libnss-dns-udeb libc6.1 libc1-dev libc6-dev-s390x
Architecture: source i386 all
Version: 2.3.5-7
Distribution: unstable
Urgency: low
Maintainer: GNU Libc Maintainers <debian-glibc@lists.debian.org>
Changed-By: Daniel Jacobowitz <dan@debian.org>
 glibc-doc  - GNU C Library: Documentation
 libc6      - GNU C Library: Shared libraries and Timezone data
 libc6-amd64 - GNU C Library: 64bit Shared libraries for AMD64
 libc6-dbg  - GNU C Library: Libraries with debugging symbols
 libc6-dev  - GNU C Library: Development Libraries and Header Files
 libc6-dev-amd64 - GNU C Library: 64bit Development Libraries for AMD64
 libc6-i686 - GNU C Library: Shared libraries [i686 optimized]
 libc6-pic  - GNU C Library: PIC archive library
 libc6-prof - GNU C Library: Profiling Libraries
 libc6-udeb - GNU C Library: Shared libraries - udeb (udeb)
 libnss-dns-udeb - GNU C Library: NSS helper for DNS - udeb (udeb)
 libnss-files-udeb - GNU C Library: NSS helper for files - udeb (udeb)
 locales    - GNU C Library: National Language (locale) data [support]
 nscd       - GNU C Library: Name Service Cache Daemon
Closes: 310047 325460 326492 326856 329043 331838 333766
 glibc (2.3.5-7) unstable; urgency=low
   [ GOTO Masanori ]
   * debian/script.in/kernelcheck.sh: Drop real-i386 kernel support.
   [ Daniel Jacobowitz ]
   * Build 64-bit packages on i386 - based on patches from both Ubuntu
     and Andreas Jochens <aj@andaco.de>.
     - Build depend on a biarch linux-kernel-headers package.
     - Build depend on new libc6-dev-amd64 package.
     - Conflict with amd64-libs to avoid stale libraries.
     - Replace files from amd64-libs-dev.
     - Use lib64 for 64-bit libraries on i386.
     - Search lib64 for ldconfig.
     - Install 64-bit headers in /usr/include/x86_64-linux-gnu.
   * Remove obsolete references to NPTL as an add-on.
   * Conflict with broken versions of libterm-readline-gnu-perl
     (Closes: #326856, #326492).
   * Merge makefile patch from Goswin Brederlow
     <brederlo@informatik.uni-tuebingen.de> to fail earlier if builds fail
     (but omit the bit for make -k check) (Closes: #325460).
   * Update debconf dependency to work with cdebconf (Closes: #331838).
   * Merge MIPS <bits/syscall.h> fix from CVS (Closes: #329043).
   * Do not complain about incompatible libraries in /etc/ld.so.conf
     (Closes: #310047).
   * Update hppa assembly for current CVS binutils.
   * Use 8-byte-aligned buffers for doubleword FPU transfers on HPPA
     (Closes: #333766).
 8fa398a004fddc60570b2ce12bf1c944 1833 libs required glibc_2.3.5-7.dsc
 f080c1cf70cefd2a572132ce63fd74ef 312058 libs required glibc_2.3.5-7.diff.gz
 3152c5a4b85d06c20f6c62900ba79d7e 3331476 doc optional glibc-doc_2.3.5-7_all.deb
 c30b0a22cb6be9367ca544af12fae29d 4060466 base standard locales_2.3.5-7_all.deb
 13b635338a97f3eaf7f6d13967fea0c2 4947416 base required libc6_2.3.5-7_i386.deb
 9c065b0d7b5453b33846d5e127d99ade 2682448 libdevel standard libc6-dev_2.3.5-7_i386.deb
 7d48fcd2e7901ec73dc4cfca17fa86ff 1266162 libdevel extra libc6-prof_2.3.5-7_i386.deb
 064c857f873f9ec30594fc00c1192ab7 1010626 libdevel optional libc6-pic_2.3.5-7_i386.deb
 22ee058599224d7acb79e66f4c3a8e92 1009438 libs extra libc6-i686_2.3.5-7_i386.deb
 e6a5e2978475ddefb0cc663761c75250 3202176 base required libc6-amd64_2.3.5-7_i386.deb
 0bf3a6d7d78c4ca6be90b4ecf0f61140 1997874 libdevel standard libc6-dev-amd64_2.3.5-7_i386.deb
 754d0ed79a57b42e712c13b42c785b73 123940 admin optional nscd_2.3.5-7_i386.deb
 ad6b004531803f80a99c18f53136b5af 6429202 libdevel extra libc6-dbg_2.3.5-7_i386.deb
 eeddaadd6b5c3afec7f08bdf4c6357ee 703136 debian-installer extra libc6-udeb_2.3.5-7_i386.udeb
 7ca7d9771936db0ac743307fa0387ba4 8270 debian-installer extra libnss-dns-udeb_2.3.5-7_i386.udeb
 d49e5882879d762231d5a7ca37d31fc1 14774 debian-installer extra libnss-files-udeb_2.3.5-7_i386.udeb
Package-Type: udeb

Version: GnuPG v1.4.2 (GNU/Linux)


Reply to: