[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#194339: marked as done (__thread problem with woody backports of gcc 3.3)



Your message dated Fri, 05 Aug 2005 19:15:42 +0900
with message-id <[🔎] 81psssu1td.wl%gotom@debian.or.jp>
and subject line Close bugs tagged as woody
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 22 May 2003 19:31:59 +0000
>From agx@sigxcpu.org Thu May 22 14:31:40 2003
Return-path: <agx@sigxcpu.org>
Received: from honk1.physik.uni-konstanz.de [134.34.140.224] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19Ivmt-0002bH-00; Thu, 22 May 2003 14:31:39 -0500
Received: from localhost (localhost [127.0.0.1])
	by honk1.physik.uni-konstanz.de (Postfix) with ESMTP
	id 8959B2BC32; Thu, 22 May 2003 21:31:37 +0200 (CEST)
Received: from honk1.physik.uni-konstanz.de ([127.0.0.1])
 by localhost (honk [127.0.0.1:10024]) (amavisd-new) with ESMTP id 05071-07;
 Thu, 22 May 2003 21:31:04 +0200 (CEST)
Received: from bogon.sigxcpu.org (kons-d9bb54e8.pool.mediaWays.net [217.187.84.232])
	by honk1.physik.uni-konstanz.de (Postfix) with ESMTP
	id 33D142BC36; Thu, 22 May 2003 21:31:04 +0200 (CEST)
Received: by bogon.sigxcpu.org (Postfix, from userid 1000)
	id 59DD31762A; Thu, 22 May 2003 21:27:33 +0200 (CEST)
Date: Thu, 22 May 2003 21:27:33 +0200
From: Guido Guenther <agx@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Cc: joey@debian.org
Subject: libc6-dev: __thread is a reserved keyword in gcc-3.3
Message-ID: <20030522192732.GA21833@bogon.ms20.nix>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="AhhlLboLdkugWU4S"
Content-Disposition: inline
X-Reportbug-Version: 1.50
User-Agent: Mutt/1.5.3i
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-18.6 required=4.0
	tests=BAYES_01,HAS_PACKAGE,PATCH_UNIFIED_DIFF,USER_AGENT_MUTT
	autolearn=ham version=2.53-bugs.debian.org_2003_05_22
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_05_22 (1.174.2.15-2003-03-30-exp)


--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: libc6-dev
Version: 2.2.5-11.5
Severity: normal
Tags: woody

/u/i/pthread.h and /u/i/bits/sigthread.h contain 3 function declartions
that use __thread as argument names. This breaks compilation of almost
any C++ program on a woody system with g++-3.3 since __thread is a
reserved keyword in this version (and pthread.h is pulled in any time
you include iostream).
A two line fix (attached) resolves this. It'd be really nice to see this
fixed in case there is another security upload for stable since I'm
sure this will annoy many people running woody when gcc-3.3 is used more
widely.
Regards,
 -- Guido

cc'ing joey since he has the final word when it comes to updates in
stable

--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="thread-keyword.dpatch"

#! /bin/sh -e

# DP: rename __thread to __thrd in header files since __thread is
# DP: reserved in gcc-3.3

if [ $# -ne 2 ]; then
    echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
    exit 1
fi
case "$1" in
    -patch) patch -d "$2" -f --no-backup-if-mismatch -p0 < $0;;
    -unpatch) patch -d "$2" -f --no-backup-if-mismatch -R -p0 < $0;;
    *)
	echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
	exit 1
esac
exit 0

--- linuxthreads/sysdeps/pthread/pthread.h.orig	Thu May 22 18:01:17 2003
+++ linuxthreads/sysdeps/pthread/pthread.h	Thu May 22 18:01:31 2003
@@ -160,7 +160,7 @@
 /* Create a thread with given attributes ATTR (or default attributes
    if ATTR is NULL), and call function START_ROUTINE with given
    arguments ARG.  */
-extern int pthread_create (pthread_t *__restrict __thread,
+extern int pthread_create (pthread_t *__restrict __thrd,
 			   __const pthread_attr_t *__restrict __attr,
 			   void *(*__start_routine) (void *),
 			   void *__restrict __arg) __THROW;
@@ -588,7 +588,7 @@
 extern int pthread_setcanceltype (int __type, int *__oldtype) __THROW;
 
 /* Cancel THREAD immediately or at the next possibility.  */
-extern int pthread_cancel (pthread_t __thread) __THROW;
+extern int pthread_cancel (pthread_t __thrd) __THROW;
 
 /* Test for pending cancellation for the current thread and terminate
    the thread as per pthread_exit(PTHREAD_CANCELED) if it has been
--- linuxthreads/sysdeps/unix/sysv/linux/bits/sigthread.h.orig	Thu May 22 18:02:14 2003
+++ linuxthreads/sysdeps/unix/sysv/linux/bits/sigthread.h	Thu May 22 18:02:16 2003
@@ -33,6 +33,6 @@
 			    __sigset_t *__restrict __oldmask)__THROW;
 
 /* Send signal SIGNO to the given thread. */
-extern int pthread_kill (pthread_t __thread, int __signo) __THROW;
+extern int pthread_kill (pthread_t __thrd, int __signo) __THROW;
 
 #endif	/* bits/sigthread.h */

--AhhlLboLdkugWU4S--

---------------------------------------
Received: (at 194339-done) by bugs.debian.org; 5 Aug 2005 10:15:49 +0000
>From gotom@debian.or.jp Fri Aug 05 03:15:49 2005
Return-path: <gotom@debian.or.jp>
Received: from omega.webmasters.gr.jp (webmasters.gr.jp) [218.44.239.78] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1E0zEy-0001Gb-00; Fri, 05 Aug 2005 03:15:49 -0700
Received: from omega.webmasters.gr.jp (localhost [127.0.0.1])
	by webmasters.gr.jp (Postfix) with ESMTP id B0A5CDEB83;
	Fri,  5 Aug 2005 19:15:42 +0900 (JST)
Date: Fri, 05 Aug 2005 19:15:42 +0900
Message-ID: <[🔎] 81psssu1td.wl%gotom@debian.or.jp>
From: GOTO Masanori <gotom@debian.org>
To: 153263-done@bugs.debian.org, 121396-done@bugs.debian.org,
	142379-done@bugs.debian.org, 153762-done@bugs.debian.org,
	159411-done@bugs.debian.org, 165760-done@bugs.debian.org,
	169758-done@bugs.debian.org, 173486-done@bugs.debian.org,
	194339-done@bugs.debian.org, 196291-done@bugs.debian.org,
	248271-done@bugs.debian.org, 294903-done@bugs.debian.org,
	165921-done@bugs.debian.org, 205039-done@bugs.debian.org,
	294483-done@bugs.debian.org, 240608-done@bugs.debian.org,
	245029-done@bugs.debian.org, 295618-done@bugs.debian.org,
	156937-done@bugs.debian.org, 161515-done@bugs.debian.org,
	188843-done@bugs.debian.org, 212697-done@bugs.debian.org,
	247223-done@bugs.debian.org, 250055-done@bugs.debian.org,
	262162-done@bugs.debian.org, 290518-done@bugs.debian.org,
	188589-done@bugs.debian.org, 209095-done@bugs.debian.org,
	debian-glibc@lists.debian.org
Subject: Close bugs tagged as woody
User-Agent: Wanderlust/2.11.30 (Wonderwall) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.4 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Delivered-To: 194339-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 14

These bugs are tagged as woody, because they're well-known problems
and for keeping open to come to light what the problem is.  However,
as you know, sarge was released.  Our stable version was moved from
woody to sarge.  It's high time to close old woody's bugs that are
still open.  Now I close these bugs.  If you have any objections to
close them, please reopen and let us know your trouble.

Regards,
-- gotom



Reply to: