[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#317857: if_fddi.h does not include netdevice.h

Package: linux-kernel-headers
Severity: serious
Tags: patch

[I'm not sure about the severity of this bug, but since it prevents a
package from building, I figured I'd take a chance.]

net-tools fails to build with the following error:

> cc -D_GNU_SOURCE -O2 -Wall  -I. -idirafter ./include/ -Ilib -I/tmp/buildd/net-tools-1.60 -idirafter /tmp/buildd/net-tools-1.60/include    -c -o fddi.o fddi.c
> In file included from /usr/include/netinet/if_fddi.h:26,
>                  from fddi.c:30:
> /usr/include/linux/if_fddi.h:110: error: field 'gen' has incomplete type
> fddi.c: In function 'in_fddi':
> fddi.c:69: warning: pointer targets in assignment differ in signedness
> make[2]: *** [fddi.o] Error 1
> make[2]: Leaving directory `/tmp/buildd/net-tools-1.60/lib'
> make[1]: *** [subdirs] Error 2
> make[1]: Leaving directory `/tmp/buildd/net-tools-1.60'
> make: *** [build-stamp] Error 2

gen is a net_device_stats structure, which is declared in netdevice.h.
The attached patch makes if_fddi.h include netdevice.h.

--- linux-kernel-headers-	2005-07-11 09:46:52.000000000 -0700
+++ linux-kernel-headers-	2005-07-11 09:47:12.000000000 -0700
@@ -24,6 +24,8 @@
 #ifndef _LINUX_IF_FDDI_H
 #define _LINUX_IF_FDDI_H
+#include <linux/netdevice.h>
  *  Define max and min legal sizes.  The frame sizes do not include
  *  4 byte FCS/CRC (frame check sequence).

Attachment: signature.asc
Description: Digital signature

Reply to: