[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#256502: debian/generate-asm.sh contains XSI:isms



Package: linux-kernel-headers
Version: 2.5.999-test7-bk-16
Severity: minor
Tags: patch

debian/generate-asm.sh contains use of the XSI:isms `-a' and `-o' in
tests.  This is technically a violation of policy.  The included patch
fixes this.

Rationale:

policy 10.4
http://www.opengroup.org/onlinepubs/009695399/utilities/test.html


Regards: David Weinehall

diff -ur linux-kernel-headers-2.5.999-test7-bk-old/debian/generate-asm.sh linux-kernel-headers-2.5.999-test7-bk/debian/generate-asm.sh
--- linux-kernel-headers-2.5.999-test7-bk-old/debian/generate-asm.sh	2004-06-27 17:19:15.000000000 +0300
+++ linux-kernel-headers-2.5.999-test7-bk/debian/generate-asm.sh	2004-06-27 17:21:20.000000000 +0300
@@ -12,7 +12,7 @@
 	cd /usr/include
 fi
 
-if [ ! -d asm-sparc -o ! -d asm-sparc64 ] ; then
+if [ ! -d asm-sparc ] || [ ! -d asm-sparc64 ] ; then
 	echo E: asm-sparc and asm-sparc64 must exist, or you will have problems
 	exit 1
 fi
@@ -34,7 +34,7 @@
 EOF
 
 	# common for sparc and sparc64
-	if [ -f asm-sparc/$h -a -f asm-sparc64/$h ]; then
+	if [ -f asm-sparc/$h ] && [ -f asm-sparc64/$h ]; then
 		cat >> asm/$h <<EOF
 #ifdef __arch64__
 #include <asm-sparc64/$h>



Reply to: